fix: clearAll() leaks audio files (#101) - #107
Merged
Merged
Conversation
…101) HistoryService.clearAll() removed transcript items but left their audio files on disk forever, so "Clear All" leaked storage. Delete each item's audio file first, matching deleteItem's deleteAudioFile: true default. Stats are intentionally left untouched — the Clear All dialog explicitly promises "keeps your statistics history," so resetting statsEntries would contradict documented behavior. Fixes #101.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101.
Problem
HistoryService.clearAll()removed transcript items but left their backing audio files on disk forever, so "Clear All" silently leaked storage:Fix
Delete each item's audio file before clearing, reusing the existing
removeAudioFileIfNeeded(for:)— the same thingdeleteItemdoes by default.Deliberately not changed: stats
The issue also expected
statsEntriesto reset. I left stats intact on purpose: the Clear All confirmation dialog explicitly says "This removes your saved transcripts, but keeps your statistics history." Resetting stats would contradict that documented promise. If you'd actually prefer Clear All to wipe stats too, that's a product decision — say the word and I'll update both the method and the dialog copy in a follow-up.Test plan