refactor: StatusCode.isError() for audit outcome checks

src/api/http.zig

@@ -53,6 +53,11 @@ pub const StatusCode = enum(u16) {
             .service_unavailable => "Service Unavailable",
         };
     }
+
+    /// true for 4xx/5xx responses.
+    pub fn isError(self: StatusCode) bool {
+        return @intFromEnum(self) >= 400;
+    }
 };
 
 pub const HttpError = error{

src/api/routes/cluster_agents/agent_routes.zig

@@ -19,7 +19,7 @@ fn nowRealSeconds() i64 {
 
 pub fn handleAgentRegister(alloc: std.mem.Allocator, request: http.Request, ctx: RouteContext) Response {
     const resp = handleAgentRegisterImpl(alloc, request, ctx);
-    if (@intFromEnum(resp.status) < 400) {
+    if (!resp.status.isError()) {
         const address = extractJsonString(request.body, "address") orelse "";
         audit.record(.agent_register, address, .ok);
     }

src/api/routes/cluster_agents/app_routes.zig

@@ -139,7 +139,7 @@ pub fn handleAppRollback(
         .content_length = release.config_snapshot.len,
     };
     const resp = deploy_routes.handleAppRollbackApply(alloc, apply_request, ctx, release.id);
-    audit.record(.app_rollback, app_name, if (@intFromEnum(resp.status) < 400) .ok else .failed);
+    audit.record(.app_rollback, app_name, if (resp.status.isError()) .failed else .ok);
     return resp;
 }
 

src/api/routes/cluster_agents/deploy_routes.zig

@@ -263,7 +263,7 @@ fn reconcileCronSchedules(db: *sqlite.Db, alloc: std.mem.Allocator, app_name: []
 pub fn handleAppApply(alloc: std.mem.Allocator, request: @import("../../http.zig").Request, ctx: RouteContext) Response {
     const resp = handleApply(alloc, request, ctx, .app, .{});
     const app_name = json_helpers.extractJsonString(request.body, "app_name") orelse "";
-    audit.record(.app_apply, app_name, if (@intFromEnum(resp.status) < 400) .ok else .failed);
+    audit.record(.app_apply, app_name, if (resp.status.isError()) .failed else .ok);
     return resp;
 }