Normalize punycode labels in extraction results#369
Open
gaoflow wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
xn--labels before assembling extraction result fields so Unicode and ACE forms produce the same suffix/fqdn.Tests:
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .tox/py310/bin/python -m pytest tests/main_test.py -k puny -q.tox/py310/bin/ruff format .uv run tox -e py310 -- -p no:gitignoreuv run tox -e lintuv run tox -e typecheckuv run tox -e codestyleNote: the local fresh tox environment installs pytest 9.1.1 and pytest-gitignore currently fails during plugin loading, so the py310 run disables only that plugin with
-p no:gitignore.Fixes #366
AI assistance was used under my direction.