Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
50ce856
feat(media): collapse idle player to app launcher
jdylanmc Sep 16, 2026
42a826a
test(media): cover idle music launcher behavior
jdylanmc Sep 16, 2026
a51a8dc
fix(media): stabilize idle launcher interactions
jdylanmc Sep 16, 2026
dea1788
test(media): cover launcher feedback and drop dead checks
jdylanmc Sep 16, 2026
956b813
fix(media): bound launcher feedback and hover
jdylanmc Sep 16, 2026
5cd88aa
fix(media): reconcile hover and shorten failures
jdylanmc Sep 16, 2026
be020d7
test(media): cover compact music hover policy
jdylanmc Sep 16, 2026
d09a278
fix(media): ignore unobserved hover exits
jdylanmc Sep 16, 2026
a2c1c9e
test(media): treat unknown hover state as no information
jdylanmc Sep 16, 2026
0b3e957
fix(media): seed compact hover from visible content
jdylanmc Sep 16, 2026
2604582
Remove idle face animation and cover Appearance output
jdylanmc Oct 2, 2026
550cb9b
Fix Appearance regression queries and preserve output failures
jdylanmc Oct 2, 2026
bde5d32
Allow an exact certificate selector for local distribution builds
jdylanmc Oct 2, 2026
fb6e3f3
Clarify optional local certificate selection and provenance
jdylanmc Oct 2, 2026
cd330da
Use optional-argument syntax for public certificate extraction
jdylanmc Oct 2, 2026
2e28bd1
Merge commit 'cd330da772ef56d0a63cb3df3cd6a1a4db4b1906' into chore/re…
jdylanmc Oct 2, 2026
5e0b458
Remove AI notification reply suggestions and add native regression
jdylanmc Oct 2, 2026
8844ddf
Merge commit '2e28bd1920265ee30d8761ad03c0b420e3f2168b' into chore/re…
jdylanmc Oct 2, 2026
6ea993e
Verify scrollable notification settings with bound real captures
jdylanmc Oct 2, 2026
3507acc
Remove haptic feedback while preserving app interactions
jdylanmc Oct 2, 2026
3c94d45
Bound General OCR alignment to measured pixel geometry
jdylanmc Oct 2, 2026
30c8500
Remove panel swipe gestures while preserving media controls
jdylanmc Oct 2, 2026
d9b0266
Clear media pulse across panel transitions and test rendered instruct…
jdylanmc Oct 2, 2026
4372043
Remove compact mode while retaining full-panel media controls
jdylanmc Oct 2, 2026
229721a
Merge commit 'd9b02661b8cf2a8c8815e0e6902be878077e4ba6' into chore/re…
jdylanmc Oct 2, 2026
cbd856a
Complete standard panel inset wiring and reconcile inherited contracts
jdylanmc Oct 2, 2026
064d1eb
Align General text evidence using bounded native-point geometry
jdylanmc Oct 2, 2026
21012df
Integrate idle launcher with retained full-panel layout and regressions
jdylanmc Oct 2, 2026
3565678
Bound music launch transactions and preserve playing-source routing
jdylanmc Oct 2, 2026
82b6530
Add owned OS media fixture and enforce its macOS contracts
jdylanmc Oct 2, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions .github/scripts/ci-contract/workflows.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,15 @@ function hostedContract(config, kind) {
{ name: 'Test helper', run: `${helper} test` },
{ name: 'Lint helper', run: `${helper} lint` },
{ name: 'Test regression pixel oracle', run: 'bash experiments/tart-regression/test-oracle.sh "$PWD/.build/regression-oracle"' },
{
name: 'Check media fixture',
run: 'mkdir -p "$PWD/.build"\n'
+ 'python3 -B experiments/tart-regression/MediaFixture/build.py check --output "$PWD/.build/mediafixture-ci"\n',
},
{
name: 'Test media fixture build recipe',
run: "python3 -B -m unittest discover -s experiments/tart-regression/MediaFixture/Tests -p 'test_build.py'",
},
] : [
{ name: 'Install contract test dependency', run: install },
{ name: 'Test workflow contracts', run: 'npm test --prefix .github/scripts/ci-contract' },
Expand Down Expand Up @@ -525,6 +534,53 @@ const mutations = [
['helper credentials persisted', 'notch_control', (c) => hostedContract(c, 'helper'), (c) => { c.jobs.validate.steps[0].with['persist-credentials'] = true; }],
['helper write permissions', 'notch_control', (c) => hostedContract(c, 'helper'), (c) => { c.permissions.contents = 'write'; }],
['helper runtime step', 'notch_control', (c) => hostedContract(c, 'helper'), (c) => { c.jobs.validate.steps.push({ run: `${helper} run inspect` }); }],
['media fixture on Ubuntu', 'notch_control', (c) => hostedContract(c, 'helper'), (c) => {
c.jobs.validate['runs-on'] = 'ubuntu-latest';
}],
['skipped media fixture job', 'notch_control', (c) => hostedContract(c, 'helper'), (c) => {
c.jobs.validate.if = 'false';
}],
['ignored media fixture job failures', 'notch_control', (c) => hostedContract(c, 'helper'), (c) => {
c.jobs.validate['continue-on-error'] = true;
}],
['missing media fixture parent directory', 'notch_control', (c) => hostedContract(c, 'helper'), (c) => {
const fixture = step(c.jobs.validate, 'Check media fixture');
fixture.run = fixture.run.replace('mkdir -p "$PWD/.build"\n', '');
}],
['media fixture app build instead of check', 'notch_control', (c) => hostedContract(c, 'helper'), (c) => {
const fixture = step(c.jobs.validate, 'Check media fixture');
fixture.run = fixture.run.replace('build.py check', 'build.py build');
}],
['filtered media fixture recipe tests', 'notch_control', (c) => hostedContract(c, 'helper'), (c) => {
step(c.jobs.validate, 'Test media fixture build recipe').run += ' -k test_check';
}],
['media fixture recipe before parent preparation', 'notch_control', (c) => hostedContract(c, 'helper'), (c) => {
const steps = c.jobs.validate.steps;
const recipe = steps.splice(steps.findIndex((s) => s.name === 'Test media fixture build recipe'), 1)[0];
steps.splice(steps.findIndex((s) => s.name === 'Check media fixture'), 0, recipe);
}],
...['Check media fixture', 'Test media fixture build recipe'].flatMap((name) => [
['missing', (c) => { c.jobs.validate.steps = c.jobs.validate.steps.filter((s) => s.name !== name); }],
['skipped', (c) => { step(c.jobs.validate, name).if = 'false'; }],
['ignored failures', (c) => { step(c.jobs.validate, name)['continue-on-error'] = true; }],
['masked exit status', (c) => {
const fixture = step(c.jobs.validate, name);
fixture.run = `${fixture.run.trimEnd()} || true`;
}],
['non-failing shell', (c) => { step(c.jobs.validate, name).shell = 'bash {0}'; }],
['before oracle gate', (c) => {
const steps = c.jobs.validate.steps;
const fixture = steps.splice(steps.findIndex((s) => s.name === name), 1)[0];
steps.splice(steps.findIndex((s) => s.name === 'Test regression pixel oracle'), 0, fixture);
}],
].map(([mutation, mutate]) => [
`${name}: ${mutation}`, 'notch_control', (c) => hostedContract(c, 'helper'), mutate,
])),
...['Check media fixture', 'Test media fixture build recipe'].map((name) => [
`${name}: added to Ubuntu contracts`, 'ci_contract_tests', (c) => hostedContract(c, 'contracts'), (c) => {
c.jobs.test.steps.push(step(workflow('notch_control').jobs.validate, name));
},
]),
['missing policy regression run', 'ci_contract_tests', (c) => hostedContract(c, 'contracts'), (c) => {
c.jobs.test.steps = c.jobs.test.steps.filter(({ name }) => name !== 'Test PR target policy');
}],
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/notch_control.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,9 @@ jobs:
run: bash scripts/notch-control/control.sh lint
- name: Test regression pixel oracle
run: bash experiments/tart-regression/test-oracle.sh "$PWD/.build/regression-oracle"
- name: Check media fixture
run: |
mkdir -p "$PWD/.build"
python3 -B experiments/tart-regression/MediaFixture/build.py check --output "$PWD/.build/mediafixture-ci"
- name: Test media fixture build recipe
run: python3 -B -m unittest discover -s experiments/tart-regression/MediaFixture/Tests -p 'test_build.py'
1 change: 0 additions & 1 deletion .swiftlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ identifier_name:
- vm
- s
- NotchLayout
- NotchPocketFaceAnimation
- MusicLiveActivity
- HelpText
- NotchBehaviour
Expand Down
31 changes: 30 additions & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,8 @@ commands. The parent reconciles the actual diff before executing any gates.
Require the human-supplied full existing **Developer ID Application** certificate
name, explicit ten-character team ID and a new canonical absolute build
directory beneath this checkout's existing `.build/`. Do not inspect Keychain,
read/copy `local.env`, import/export certificates or embed personal selectors.
read/copy `local.env`, import/export Keychain certificates or private keys, or
embed personal selectors.
No path reuse, overwriting, input-app mutation, installation or app launch:

```bash
Expand All @@ -249,6 +250,34 @@ python3 -B scripts/distribution.py \
--build-dir "$PWD/.build/np9-signing-001"
```

The canonical command retains existing full-name selection without an extra
flag. **Optional variant for duplicate certificate names:**

```bash
python3 -B scripts/distribution.py \
--identity 'Developer ID Application: YOUR CERTIFICATE NAME (YOURTEAMID)' \
--team 'YOURTEAMID' \
--certificate-sha1 'PUBLIC_CERTIFICATE_SHA1_40_HEX_CHARACTERS' \
--build-dir "$PWD/.build/np9-signing-sha1-001"
```

`--certificate-sha1` belongs to **`scripts/distribution.py` only**.
`scripts/notarize.py` DMG signing and the hosted release pipeline remain
name-selected and unchanged; neither accepts or forwards this option.
The optional public leaf fingerprint uses exactly 40 hexadecimal characters
(either case, no separators or prefix). Name and team remain mandatory.
Use a human-provided known certificate fingerprint, or the
[README's artifact-only extraction example](README.md#local-developer-id-candidate-9-bounded-slice)
with an explicit already-approved signed artifact:
`codesign --extract-certificates` into a new task-owned temporary directory, then
`openssl x509` for the public leaf's SHA-1 fingerprint. This is public artifact
metadata only, not permission for Keychain inspection/enumeration, access
changes, private-key export or artifact mutation. Extraction is not signature
verification or proof that the signing identity is usable. The fingerprint
selects Xcode/resource/outer-app signing and constrains every final bundle/Mach-O
verification on all architectures; chain, name/team and all other signature
checks remain required. No fallback to the common name on failure.

The parent creates the `.build/` parent if needed and substitutes the approved
selector/team; placeholders are not configured values. The command discovers
full Xcode 26+ (rejecting invalid explicit `DEVELOPER_DIR` or CLT-only setups),
Expand Down
37 changes: 32 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ hosted run or distribution succeeded.
| [Native helper](.github/workflows/notch_control.yml) | Unfiltered `pocket` push/PR on `macos-26`, read-only contents, non-persisted checkout credentials, 20-minute timeout. Canonical build, all 69 package tests, and exactly ten Swift lint inputs. No app launch, screenshots, privacy grants, signing secrets, or publication. |
| [CI contracts](.github/workflows/ci_contract_tests.yml), [tests/package](.github/scripts/ci-contract/) | Unfiltered `pocket` push/PR, read-only contents, non-persisted credentials, five-minute timeout. Node's built-in test runner and one exact-pinned YAML parser inspect actual workflow structure, reject malformed/duplicate YAML, and test deliberately mutated configurations. Workflow `run` blocks are data, never executed by these structural tests. Also runs the existing 22 PR-policy tests and the named portable local-packaging, distribution-signing, notarization-preparation and hosted-release unittest steps; no native signing, packaging or uploads on Ubuntu. |
| [Local packaging](scripts/package.py), [portable tests](scripts/tests/test_package.py) | Explicit already-built Release app and new DMG paths; Python 3.9+ standard library, existing hash-pinned DMG builder unchanged. Native identity/signature checks, private copy, read-only image verification, exact-input content comparison, owned-device detach, no-clobber promotion. No implicit build/sign/install/launch, secrets, `local.env`, release credentials, or publication. See [usage and missing-dependency recovery](README.md#local-dmg-preparation). |
| [Local distribution signing](scripts/distribution.py), [portable tests](scripts/tests/test_distribution.py) | Separately approved NP-9-local-signing-v1: explicit existing Developer ID Application name/team and a fresh private build directory. Xcode Release signing overrides, planned signing of the resource-only MediaRemoteAdapterTestClient plus outer app seal, and all-Mach-O/all-architecture signature evidence. Existing local defaults and packager unchanged. **NOT YET NOTARIZED**; no Keychain management, installation, app launch or publication. See [usage](README.md#local-developer-id-candidate-9-bounded-slice). |
| [Local distribution signing](scripts/distribution.py), [portable tests](scripts/tests/test_distribution.py) | Separately approved NP-9-local-signing-v1: explicit existing Developer ID Application name/team, optional public certificate SHA-1 selector and a fresh private build directory. Xcode Release signing overrides, planned signing of the resource-only MediaRemoteAdapterTestClient plus outer app seal, and all-Mach-O/all-architecture signature evidence. Existing local defaults and packager unchanged. **NOT YET NOTARIZED**; no Keychain management, installation, app launch or publication. See [usage](README.md#local-developer-id-candidate-9-bounded-slice). |
| [Notarization preparation](scripts/notarize.py), [portable tests](scripts/tests/test_notarize.py) | Explicit signed app, signer/team, existing notarytool profile and fresh output directory. Copies without changing the source, notarizes/staples the app, reuses exact-input packaging, then signs/notarizes/staples and verifies the final DMG. Native execution uploads to Apple; portable CI does not. No GitHub/Homebrew publication or installation. See [release gates and recovery](docs/releases.md). |
| [Notch Pocket notarized release](.github/workflows/pocket-native-release.yml), [portable boundaries](scripts/tests/test_pocket_release.py) | Product tag `notch-pocket-v*` or explicit existing-tag dispatch from `pocket`; strict version/ancestry gate and all nine successful exact-commit product jobs from the latest `pocket` push runs. Separate hosted macOS 26 / full Xcode 26.6 signing job uses isolated temporary credentials; Ubuntu publication checks transferred and remote asset bytes before publishing a draft as latest. Final DMG plus public manifest only. Scoped Homebrew token opens a draft cask PR, never merges or writes `main`. Empty configuration fails with named missing secrets. See [setup, permissions and recovery](docs/releases.md#hosted-actions-workflow). |
| [PR target check](.github/workflows/base_ref_check.yml), [guidance](.github/workflows/base_ref_check_comment.yml) | Existing `pull_request_target` events and check identities remain unchanged: `Fork PR target check` and `Sync PR target guidance comment`. Only `pocket` is an allowed base. Guidance uses its existing comment permissions; product-CI changes do not broaden them. |
Expand Down Expand Up @@ -293,7 +293,7 @@ Neither an owned partial output nor a competing output is deleted.

### Local distribution signing outcome and evidence

`scripts/distribution.py --identity FULL_DEVELOPER_ID_NAME --team TEAM_ID --build-dir ABSOLUTE_NEW_BUILD`
`scripts/distribution.py --identity FULL_DEVELOPER_ID_NAME --team TEAM_ID --build-dir ABSOLUTE_NEW_BUILD [--certificate-sha1 PUBLIC_CERTIFICATE_SHA1_40_HEX_CHARACTERS]`
is the **NP-9-local-signing-v1** entrypoint. Follow the
[exact signed-app → existing packager workflow](README.md#local-developer-id-candidate-9-bounded-slice).
It never loads `local.env`, changes project/local-test signing defaults, touches
Expand All @@ -302,6 +302,29 @@ submits anything to Apple. Existing app/helper IDs, version 0.1.0 and declared
entitlements are checked, not overridden. The helper's existing sandbox `false`
entitlement is retained rather than replaced with app entitlements.

The optional `--certificate-sha1` disambiguates certificates sharing the same
common name without enumerating identities. It accepts exactly 40 hexadecimal
characters (case-insensitive, no separators/prefix); an empty or malformed value
fails before tool discovery or build-directory creation. Missing option values
are argument errors. The full name and team remain required, even with a
fingerprint. The normalized uppercase fingerprint replaces only the native
signing selector, in both Xcode and the resource/outer-app `codesign --sign`
commands. Omitting it preserves full-name selection and the existing result
shape. An unavailable certificate is a native build/signing failure, not
permission to retry by name or change credentials.

`--certificate-sha1` belongs to **`scripts/distribution.py` only**.
`scripts/notarize.py` DMG signing and the hosted release pipeline remain
name-selected and unchanged; neither accepts or forwards this option.
Use a human-provided known public certificate fingerprint, or follow the
[README's artifact-only extraction example](README.md#local-developer-id-candidate-9-bounded-slice):
`codesign --extract-certificates` reads the embedded public certificate of an
already-approved signed artifact into a new task-owned temporary directory, then
`openssl x509` reports the leaf's SHA-1 fingerprint. No Keychain inspection or
enumeration, private-key export, or artifact mutation is authorized. This does
not replace any signer, chain, team, timestamp, runtime, entitlement or
all-architecture verification below.

The explicit plain command-line `CODE_SIGN_IDENTITY=...` and
`DEVELOPMENT_TEAM=...` overrides take precedence over project settings, including
SDK-conditional identities. Do not pass `CODE_SIGN_IDENTITY[sdk=macosx*]=...`
Expand Down Expand Up @@ -340,7 +363,11 @@ loosen the contract.

Final verification requires the Apple Developer ID Application certificate
chain and supplied team using an inline `codesign -R` requirement; both app
and helper also require their exact identifiers. Every physical Mach-O file,
and helper also require their exact identifiers. If a fingerprint was supplied,
the requirement additionally includes `certificate leaf = H"<40_HEX_SHA1>"`.
It checks Xcode-signed code before resource signing, then every bundle and
physical Mach-O file during final verification, with `--all-architectures`.
A different leaf fails even if its common name and team match. Every physical Mach-O file,
including nested resources and framework versions, is verified for all
architectures and inspected per architecture for the requested certificate
name, team, hardened-runtime flag, secure `Timestamp` (not merely `Signed Time`)
Expand All @@ -351,9 +378,9 @@ remain sealed resources, not a claim about interpreter runtime policy.

| Exit | Outcome |
| --- | --- |
| 0 | `ok: true`, `status: "signed"`; exact `app`, `build_dir`, `configuration`, `version`, developer directory, team, app/helper identifiers and `code` evidence for each architecture |
| 0 | `ok: true`, `status: "signed"`; exact `app`, `build_dir`, `configuration`, `version`, developer directory, team, app/helper identifiers and `code` evidence for each architecture; uppercase public `certificate_sha1` only when supplied and verified |
| 2 | `invalid_arguments`; no supplied argument contents echoed |
| 3 | `invalid_input`; invalid identity/team, unsafe paths or entitlement declarations |
| 3 | `invalid_input`; invalid identity/team/certificate SHA-1, unsafe paths or entitlement declarations |
| 4 | `missing_tool`, `unsupported_platform`; full Xcode 26+/macOS 15.6+ required |
| 5 | `signature_failed`; no fallback, with original `tool_exit` when a native signing/verification command failed |
| 6 | `build_failed`; original Xcode `tool_exit`, or explicit `timed_out` |
Expand Down
Loading
Loading