Repository navigation
Conversation
Reuse the selected music source without starting playback. Keep both layouts and adjacent widgets intact; surface target and launch failures. Refs #53 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author pure behavioral coverage for the agreed #53 seam before the implementation exists: presentation collapse/restore policy, launch target resolution, and explicit launcher outcomes. - The music section stays visible in both presentations, proving a collapse rather than hiding or disturbing unrelated section state. - Now Playing resolves the current then remembered bundle identifier and never falls back to Apple Music when no target exists. - The workspace boundary exposes only lookup and open, so launching cannot reach playback controls. Compile-red is UNVERIFIED: native execution is locked by #75. Refs #53
Retain compact hover bounds without keeping transport visible. Show dismissible inline failures in the nonactivating panel, keep bundle IDs out of user feedback, and guard repeated launch clicks. Refs #53 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Follow the accepted production contract change for #53. - Drop the isSectionVisible assertion; the property is removed, so the expectation could no longer fail for any defect. - Drop the resume-restoration and purity presentation tests. The policy is a stateless function of isPlaying, so both only restated the two remaining cases instead of detecting an independent defect. - Cover MusicAppFeedback display names and outcome messages, including trimming, unknown and blank identifiers, and every failure outcome. - Assert raw bundle identifiers never reach rendered user-facing text. Compile-red is UNVERIFIED: native execution remains locked. Refs #53
Keep launch errors inside existing music bounds without holding the panel open. Track compact hover independently of hit testing so pause-under-pointer retains hover, not an invisible gesture target. Refs #53 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ignore unmeasured hover bounds and reconcile after SwiftUI layout. Keep failure feedback readable without scrolling, and prevent an ended feedback gesture from reaching the panel-close threshold. Refs #53 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pin the pure hover seam for the collapsed launcher in #53 so the view layer keeps a single decision point. - Degenerate bounds report no state whatever the pointer, hidden flag or previous value, so an unlaid-out section cannot latch hover. - Hiding ends hover even while the pointer sits inside the old frame. - Unchanged states report nil rather than republishing the same value. - Boundary cases follow CGRect.contains: the origin corner is inside, the far edges are outside, and the frame origin is honored instead of size alone. Compile-red is UNVERIFIED: native execution remains locked. Refs #53
Coalesce pending hover reconciliation and keep unknown-player errors as complete sentences. Refs #53 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Correct the compact launcher hover expectations for #53. An absent previous value carries no evidence that hover ever began, so a not-hovering computation must stay silent instead of publishing an exit the view never entered. - Unknown previous state with the pointer outside, or while hidden, now reports nil. - Only an observed hover can produce false, whether the pointer leaves or the section hides. - A previously not-hovering state stays silent in both cases. Names now state the intent rather than the inputs. Degenerate-bounds and containment-edge expectations are unchanged. Compile-red is UNVERIFIED: native execution remains locked. Refs #53
Carry the known hover state into each new native tracking view without resetting observations during subsequent SwiftUI updates. Refs #53 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…move-compact-mode # Conflicts: # experiments/tart-regression/README.md # experiments/tart-regression/scenarios/general-haptics-removed.md # experiments/tart-regression/scenarios/general-panel-swipes-removed.md
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#53: preferred-app launcher in the retained full panel
Draft: independent native acceptance is still incomplete. This continues the existing PR, integrates #106/#107 without restoring compact mode, and fixes the original SwiftLint failures. No release or host installation is included.
Validation and reviews
35656780a87613fa95e8b873c687a6275b222d73: all sixteen local gates passed. App 241, helper 69, workflow 170, PR policy 22, Python 319 and oracle 16,846 tests/cases; standalone harness build passed.d6d58fe0369a6855f7854bad84afe2607d86ddc019ff923b6a4af7676b998d8a; six code files/thirteen architecture signatures verified with the approved Developer ID identity. Not notarized.82b65308bfd53b95d24fd50610d5677b2ffa9024adds only a distinct test-only OS media fixture and its additive macOS CI gates. Production source matches the signed candidate. Updated workflow contracts: 191 passed; fixture recipe tests: seven passed; fixture state/storage/audio contracts: six groups passed.Remaining native gate
The runner prerequisite is complete: #108 is merged into
pocketat
b8b70228d82bd0e8b208c2e34b4c94f6670fd9b2. Protected stable-signedrunners, exact-source/package verification and the unattended update model
are delivered. The updated runner passed admission plus the full nine-case
registry on two fresh headless boots: 20 native tests, 18/18 expected suite
outcomes, zero skips, and true recording preflight before and after every test.
No additional human interaction, grant or reset was needed during that proof.
Artifact inventory and app/UI/process/job/lock cleanup were verified.
This is the configured runner's bounded acceptance, not this feature's
candidate-specific acceptance or whole-app coverage. The old timeout,
restoration and metadata failures remain preserved; they are no longer the
current runner blocker.
The runner path is now qualified. This PR still needs both error journeys
and real OS Now Playing play/pause/stop/resume plus activation without playback
through the distinct fixture. Actual Spotify-account behavior remains
separate. Do not substitute unit results, Settings pixels or producer counters.
Historical hosted checks passed at
82b65308bfd53b95d24fd50610d5677b2ffa9024(observed before the #108 merge); refresh current head/base readiness before landing.The old administrative MACL reports remain immutable. A separate contract reassessment credits their demonstrated signed-content/native-output facts without claiming universal filesystem-metadata or permission-state equality. No blanket metadata exemption or attribute stripping occurred.
Host installation, personal media/accounts, prepared baseline and unrelated PR97 remain untouched. Earlier failures and private evidence are preserved.
Integration freshness after the runner merge
Before landing, reconcile this change against current
pocket, includingmerged #108, and refresh actual head/base review and CI evidence. Prepare new
exact-source candidates/fixtures whenever integration changes their inputs.
Historical green checks are not automatically current-base readiness.
This reconciliation changes the description only; it does not update this
branch, rerun tests, mark the draft ready, or authorize a merge.
Factual reconciliation after #108 merged into
pocketatb8b70228d82bd0e8b208c2e34b4c94f6670fd9b2on 2026-10-04 UTC(2026-10-03 evening EDT). Remaining issue/PR states, priorities and ownership
are unchanged. This update does not run tests, integrate branches, merge
other work, change permissions, install an app or publish a release.