Skip to content

Document AgiBot keyboard/SpaceMouse teleop environments#6109

Open
rwiltz wants to merge 1 commit into
isaac-sim:developfrom
rwiltz:rwiltz/docs-agibot-teleop-envs
Open

Document AgiBot keyboard/SpaceMouse teleop environments#6109
rwiltz wants to merge 1 commit into
isaac-sim:developfrom
rwiltz:rwiltz/docs-agibot-teleop-envs

Conversation

@rwiltz

@rwiltz rwiltz commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Description

Adds the two AgiBot place tasks to the Keyboard and SpaceMouse Environments
reference table in docs/source/features/isaac_teleop.rst:

  • Isaac-Place-Mug-Agibot-Left-Arm-RmpFlow-v0
  • Isaac-Place-Toy2Box-Agibot-Right-Arm-RmpFlow-v0
    Both environments expose teleop_devices (keyboard, SpaceMouse) and use RMPFlow
    arm control with a binary gripper, but were absent from the table even though
    their Galbot/UR10 peers are listed. They use the legacy isaaclab.devices stack,
    so they belong

Fixes # (issue)

Type of change

  • Documentation update

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Add the two keyboard/SpaceMouse AgiBot place environments
(Isaac-Place-Mug-Agibot-Left-Arm-RmpFlow-v0 and
Isaac-Place-Toy2Box-Agibot-Right-Arm-RmpFlow-v0) to the
Keyboard and SpaceMouse Environments reference table.

Both configs expose teleop_devices (keyboard, SpaceMouse) and use
RMPFlow arm control with a binary gripper, matching the documented
Galbot RMPFlow tasks, but were missing from the table.

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation Review — PR #6109

Summary: This PR adds two AgiBot place-task environments (Isaac-Place-Mug-Agibot-Left-Arm-RmpFlow-v0 and Isaac-Place-Toy2Box-Agibot-Right-Arm-RmpFlow-v0) to the Keyboard and SpaceMouse Environments reference table in isaac_teleop.rst.

✅ What Looks Good

  • Correct placement: The entries are inserted adjacent to the existing Galbot entries (which also use RMPFlow), maintaining logical grouping by robot platform.
  • Consistent formatting: The RST list-table syntax matches the surrounding entries (indentation, field separators, inline bold markup).
  • Accurate descriptions: The arm control method (RMPFlow end-effector pose) and gripper trigger (K / left SpaceMouse button) are clearly documented and consistent with how similar entries describe their controls.

💡 Minor Suggestions (non-blocking)

  1. Consider adding a task description prefix: Other entries in the table include a brief mention of the task objective (e.g., "Same as left-arm gripper above…"). These two entries jump straight to control descriptions. Adding a short phrase like "Place mug task." or "Place toy into box." before the arm/gripper details would help readers understand what the environment does at a glance.

  2. Ordering within the table: The new AgiBot entries sit between the Galbot visuomotor entry and the UR10 entry. If there is an intended ordering convention (alphabetical by robot, or grouped by robot family), it may be worth double-checking placement. Currently it reads naturally since Galbot → AgiBot → UR10 groups bimanual/humanoid platforms together.

🔍 Verification Notes

  • No code changes — documentation only (8 additions, 0 deletions in a single .rst file).
  • RST indentation appears correct (3-space continuation for multi-line descriptions within the list-table directive).
  • No broken cross-references or directives introduced.

Overall: Clean, minimal, and well-scoped docs addition. LGTM with the minor readability suggestion above. 🚀

@greptile-apps

greptile-apps Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds two missing AgiBot place-task environments to the keyboard/SpaceMouse teleop reference table in docs/source/features/isaac_teleop.rst. Both environment IDs are confirmed to exist in the task registry and are correctly configured with teleop_devices (keyboard + SpaceMouse) and RMPFlow arm control.

  • Adds Isaac-Place-Mug-Agibot-Left-Arm-RmpFlow-v0 (left-arm, gripper) and Isaac-Place-Toy2Box-Agibot-Right-Arm-RmpFlow-v0 (right-arm, gripper) to the table, consistent with how peer Galbot and UR10 entries are documented.
  • Placement between the Galbot Visuomotor entry and the UR10 entries groups robots logically and keeps the table coherent.

Confidence Score: 5/5

Documentation-only change; both environment IDs exist in the task registry with matching arm sides and teleop device configurations.

Both added environment IDs are confirmed present in the task registry. The left/right arm designations match the actual joint configuration in the respective env config files. Both configs have teleop_devices set up with keyboard and SpaceMouse as described. The table placement is consistent with existing entries.

No files require special attention.

Important Files Changed

Filename Overview
docs/source/features/isaac_teleop.rst Adds two AgiBot place-task entries to the keyboard/SpaceMouse environment table; environment IDs, arm sides, and device descriptions are accurate.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[isaac_teleop.rst Table] --> B[Galbot entries]
    A --> C[Agibot entries - NEW]
    A --> D[UR10 entries]
    A --> E[Franka entry]
    C --> C1["Isaac-Place-Mug-Agibot-Left-Arm-RmpFlow-v0\nDevices: Keyboard, SpaceMouse\nArm: left-arm RMPFlow | Gripper: K / left btn"]
    C --> C2["Isaac-Place-Toy2Box-Agibot-Right-Arm-RmpFlow-v0\nDevices: Keyboard, SpaceMouse\nArm: right-arm RMPFlow | Gripper: K / left btn"]
Loading

Reviews (1): Last reviewed commit: "Document AgiBot teleop envs in Isaac Tel..." | Re-trigger Greptile

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant