fix(embed): scope embed CSS, navbar brand toggle, playback scrubber, and layout guard (v1.5.2)#12
Merged
Conversation
Disable global preflight and inject an equivalent reset under #rosview-root so importing @ioai/rosview/style.css no longer resets host navbar/button styles.
Expose showNavbarBrand and navbarBrandLabel on RosViewer so hosts can hide or replace the default ROS View label, and document CSS scoping plus branding in the English and Chinese embedding guides.
…lotChart logic Introduce a new utility function to determine if the X axis should be pinned to the full log range during incremental updates. Update the usePlotChart implementation to utilize this function, ensuring the X scale remains consistent while data is loading. Additionally, refine the scoped preflight CSS for better integration with the host application.
…1.5.2) Scope playback progress layers with pointer-events-none so the track receives pointer events in embedded hosts. Center the thumb and hover line with Tailwind translate utilities under #rosview-root. Only reapply auto-layout when preferAutoLayout is enabled, so host initialLayout is not replaced after topics finish loading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release v1.5.2 with embed-host fixes and Plot panel improvements carried from the 1.5.1 line.
Embed / host integration
#rosview-rootonly (preflight: false+ scoped base rules) so host apps (e.g. Next.js + Tailwind v4) are not affected by global resets onbutton,body, etc.showNavbarBrandandnavbarBrandLabelonRosViewerso hosts can hide the left “ROSView” brand while keepingnavbarSourceNamefor the dataset title.EMBEDDING.md/EMBEDDING.zh.md.pointer-events-noneso scrubbing works onplayback-track; thumb/hover line centered with Tailwindtranslateutilities under#rosview-root.reapplyAutoLayoutwhenpreferAutoLayoutis true, so a host-providedinitialLayoutis not overwritten after topics finish loading.Plot panel
shouldPinPlotXScaleToLogRangeand related chart/data pipeline updates.Motivation / related issue
Embedded consumers (e.g. Limx agent-manager
/visualize) reported:@ioai/rosview/style.css(global preflight leakage).initialLayoutreplaced by auto 3D/Pose layout once topics loaded whenpreferAutoLayoutwas off.Type of change
Checklist
npm run lintpasses with no errorsnpm testpasses (unit tests)npm run buildandnpm run build:libsucceedAPI compatibility
Additive (non-breaking)
RosViewer/RosViewContent/AppShell:showNavbarBrand?: boolean(defaulttrue)RosViewer:navbarBrandLabel?: string(optional custom brand text)Behavior fixes (no export changes)
#rosview-rootDockviewLayout: auto-layout reapply gated onpreferAutoLayoutPlaybackBar: pointer hit-testing and thumb positioning via Tailwind classesPlot panel
src/entrypoints/index.tsfor embed API.N/A for removed exports.
Screenshots / recordings