Skip to content

fix: only add mise shims to PATH in use-mise #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bo0tzz merged 1 commit into from
Oct 14, 2026
Merged

fix: only add mise shims to PATH in use-mise #2010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions actions/use-mise/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@ runs:
working_directory: ${{ inputs.working_directory }}
cache_key_prefix: ${{ inputs.working_directory }}
install_args: "--locked"
export_path: false
version: 2026.10.5
Comment on lines +20 to 21

@futo-kritika futo-kritika Bot Oct 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Test the shims-only PATH contract · tests

When export_path: false is removed or accidentally re-enabled, the existing use-mise workflow still passes: it checks only token forwarding and the mise version, neither of which distinguishes direct tool-bin PATH exports from shims. Add a PATH regression check so the mobile-build failure this change addresses cannot silently return.

Suggested fix

Extend .github/workflows/test-use-mise.yml to assert that command -v node resolves through the mise shims directory, that $(mise where node)/bin is absent from PATH, and that node --version succeeds on the existing runner matrix.

Prompt for a coding agent 
Add a regression step to .github/workflows/test-use-mise.yml after the local use-mise action runs. Assert that command -v node resolves to the mise shims directory, that the Node installation's bin directory (obtained with mise where node) is not an entry in PATH, and that node --version still succeeds. Keep this step in the existing runner matrix so changing or removing export_path: false causes the test to fail.

Loading