[bo0tzz]

mise-action v5 also puts each tool's bin directory on PATH. That broke immich's mobile build (run): Flutter's build hooks now hit the mise rustup shim with a stripped environment, and it fails the trust check. This goes back to only adding the shims directory to PATH, as use-mise v3.2.1 did.

[futo-kritika]

Kritika Review

Disables mise tool-bin PATH exports while retaining shims.

1 finding · 1 P2

Confidence 5/5 · medium risk: The risk rests on a single input in a shared CI action that changes how tools reach PATH for every consumer. A revert undoes it, and the account confirms the pinned upstream supports export_path and still adds shims by default. I agree with the P2 finding, which doesn't lower the score.

Approved

Findings

• actions/use-mise/action.yml:20 Test the shims-only PATH contract · tests

Summary

The action now disables direct mise PATH exports while retaining the upstream default that adds shims. The pinned upstream implementation supports this separation. A regression assertion for the resulting PATH would protect the behavior this fix restores.

What's good

• Uses the upstream PATH-specific switch without disabling other mise environment exports.

Sources consulted

• https://redirect.github.com/jdx/mise-action/tree/2d8d4cafcbd33be2ea37d2b6f5ad595363d1f1ca

Commands offered: curl, fd, gh, jq, rg, yq; run: rg.

_{Reviews (1) · Last reviewed commit: "fix: only add mise shims to PATH in use-..." · openai/gpt-6.1-sol · $0.04}

[futo-kritika]

Test the shims-only PATH contract · tests

When export_path: false is removed or accidentally re-enabled, the existing use-mise workflow still passes: it checks only token forwarding and the mise version, neither of which distinguishes direct tool-bin PATH exports from shims. Add a PATH regression check so the mobile-build failure this change addresses cannot silently return.

Suggested fix

Extend .github/workflows/test-use-mise.yml to assert that command -v node resolves through the mise shims directory, that $(mise where node)/bin is absent from PATH, and that node --version succeeds on the existing runner matrix.

Prompt for a coding agent

Add a regression step to .github/workflows/test-use-mise.yml after the local use-mise action runs. Assert that command -v node resolves to the mise shims directory, that the Node installation's bin directory (obtained with mise where node) is not an entry in PATH, and that node --version still succeeds. Keep this step in the existing runner matrix so changing or removing export_path: false causes the test to fail.

[futo-kritika]

kritika: confidence 5/5 with medium risk at ebb3ca5.