Prove native Tabs assembly, editing and frontend persistence - #120
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Native Tabs were registered but lacked an explicit input contract and editor persistence proof. Closes #117.
Solution
Qualify the existing generic assembler without changing production code. The guide now supplies both native label locations and limits the claim to page content.
dev/test/intent-tabs.test.tsscripts/proof-tabs-playwright.mjsvitest.wordpress.config.tsDiff
+551 −2 · 7 files · no production API change
Testing & verification
Reviewed revision:
c564240· Node 22.23.1, WordPress 7.1, PHP 8.3.35, Chromium 149.0.7827.55.npm run verifypassed: 709 tests passed, four existing skips; typecheck, build, corpus hashes and package checks passed.npx --no-install vitest run dev/test/intent-tabs.test.ts dev/test/intent-query.test.ts dev/test/intent.test.ts dev/test/engine-skill.test.ts dev/test/skill.test.tspassed: 23 tests. The final guide edit additionally passed both skill suites (eight tests).npx --no-install vitest run --config vitest.wordpress.config.ts dev/test/proof-tabs-wordpress.test.tspassed. Initial cold container startup timed out; the retained rerun passed after completing the same owned environment. Both save/reopen pairs had equal content hashes, clean reopened state and no invalid blocks. Arrow keys moved focus; Enter/Space activated tabs, matching the native control./tmp/block-runner-tabs-evidence/tabs; CI retains the same evidence under its existing WordPress artifact root.git diff --check ff52333passed.Not verified: nested Tabs, registered-block label fields/overrides, model conversion quality, manual visual acceptance or a release. No model benchmark ran.
Risk / rollout
Production assembly is unchanged. The added browser proof requires the existing WordPress/Chromium prerequisites and retains failures instead of skipping them. The label rule follows Core metadata; keyboard assertions follow Core actions.
Detection: headless or WordPress CI fails on a persistence regression. Rollback: revert this PR; no migration or published package is involved.