Skip to content

fix: make main CI green (stacked fmt + clippy + fuzzy-test fixes)#15

Merged
hev merged 3 commits into
mainfrom
fix/main-ci-green
Jul 8, 2026
Merged

fix: make main CI green (stacked fmt + clippy + fuzzy-test fixes)#15
hev merged 3 commits into
mainfrom
fix/main-ci-green

Conversation

@hevbot

@hevbot hevbot commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

What was broken

Main CI was red in three independent slices, while sibling PRs each fixed only one lane:

What this stacks

Closes #11.
Closes #13.

After this lands, #10 should rebase onto a green main CI baseline.

Local verification

./scripts/cargo fmt --check
# passed

cargo clippy --workspace --all-targets -- -D warnings
# Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 16s

./scripts/cargo test -j 2 -p hevsearch-core --test manager_local_fs local_fs_fuzzy_fts_matches_typo_query -- --exact --nocapture
# test local_fs_fuzzy_fts_matches_typo_query ... ok
# test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 16 filtered out; finished in 0.19s

@hevbot hevbot added the gate:impl Implementation PR awaiting CI + spec-review + merge (agentic-gates §2) label Jul 8, 2026
@hevbot

hevbot commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

Follow-up after the first #15 CI run:

  • Remote cargo fmt passed.
  • Remote cargo clippy --workspace --all-targets -- -D warnings passed.
  • Remote cargo test --workspace --no-fail-fast passed.
  • Remote ignored MinIO integration tests then failed in service_semantic_cache / service_result_projection because those semantic-cache fixtures created default single-vector namespaces, now L2, then opted into semantic cache.

Pushed 9deb022 test: seed semantic-cache fixtures with cosine metric, which makes those semantic-cache test preconditions explicit by seeding the fixtures with DistanceMetric::Cosine. Local ./scripts/cargo fmt --check and cargo clippy --workspace --all-targets -- -D warnings pass after the patch. A scoped local MinIO rerun could not validate assertions because the existing local service on 127.0.0.1:9000 rejected the repo/CI default minioadmin credentials with InvalidAccessKeyId; CI starts a fresh MinIO with those credentials.

@hev hev merged commit 42a6bca into main Jul 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gate:impl Implementation PR awaiting CI + spec-review + merge (agentic-gates §2)

Projects

None yet

2 participants