Skip to content

docs: finalize RFC 0005 — arbitrary string row ids (accept)#21

Merged
hev merged 1 commit into
mainfrom
docs/rfc-0005-finalize
Jul 8, 2026
Merged

docs: finalize RFC 0005 — arbitrary string row ids (accept)#21
hev merged 1 commit into
mainfrom
docs/rfc-0005-finalize

Conversation

@hevbot

@hevbot hevbot commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Links issue #20. This intentionally does not close it; implementation follow-up issues can be filed after merge.

Rendered links:

Resolved open questions:

  • Enum vs branch: resolved to RowId / RowIdType enums end to end. Evidence: crates/hevsearch-core/src/result.rs.
  • Schema choice: resolved to per-namespace UInt64 or Utf8 in schema_for_kind. Evidence: crates/hevsearch-core/src/manager.rs.
  • Mixed-type writes: resolved to fixed namespace id_type; wrong-type upsert/import/delete rejects. Evidence: upsert, import_arrow_with_distance_metric, delete_ids.
  • Cursor re-encode: resolved to versioned v1:u / v1:s tokens with legacy numeric decode. Evidence: encode_list_cursor, decode_list_cursor, cursor unit tests.
  • Import: resolved to Arrow id as UInt64 or Utf8, checked against existing namespaces. Evidence: validate_arrow_import_schema.
  • Delete quoting: resolved through RowId::to_sql_literal before id IN (...). Evidence: string delete quote regression tests.
  • Multivector + string id: resolved as independent of vector kind. Evidence: validate_arrow_import_schema test with id: Utf8 plus vectors.

Open question for review:

  • String id length bound: current code does not appear to enforce one. The RFC flags whether to accept unbounded Utf8 ids or file a follow-up implementation issue for a concrete byte limit.

Validation:

  • Docs-only change: docs/rfcs/0005-arbitrary-row-ids.md is the only touched file.
  • git diff --check passes.
  • No cargo suite run; this is docs-only, and the protected fmt/clippy/test lane will still run on the PR.

@hevbot hevbot added the gate:docs Awaiting docs review gate (agentic-gates §2) label Jul 8, 2026
@hevbot

hevbot commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

Factory verified: diff touches only docs/rfcs/0005-arbitrary-row-ids.md; rendered links in body; open questions explicitly flagged for review. Branched from post-#15 green main — required check should pass on its own. Ready for hev's docs review; merge = RFC accepted + factory files implementation issues.

@hev

hev commented Jul 8, 2026

Copy link
Copy Markdown
Owner

@hevbot deal with the merge conflict here

@hev hev force-pushed the docs/rfc-0005-finalize branch from a25da5f to 4a74805 Compare July 8, 2026 19:00
@hevbot

hevbot commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

No actual merge conflict — GitHub was showing the out-of-date-with-base banner (state was MERGEABLE/BEHIND). Branch updated onto post-#18 main; CI re-running; merge when green.

@hev hev merged commit 74870b4 into main Jul 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gate:docs Awaiting docs review gate (agentic-gates §2)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants