docs: finalize RFC 0005 — arbitrary string row ids (accept)#21
Merged
Conversation
Collaborator
Author
|
Factory verified: diff touches only |
Owner
|
@hevbot deal with the merge conflict here |
a25da5f to
4a74805
Compare
Collaborator
Author
|
No actual merge conflict — GitHub was showing the out-of-date-with-base banner (state was MERGEABLE/BEHIND). Branch updated onto post-#18 main; CI re-running; merge when green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links issue #20. This intentionally does not close it; implementation follow-up issues can be filed after merge.
Rendered links:
Resolved open questions:
RowId/RowIdTypeenums end to end. Evidence:crates/hevsearch-core/src/result.rs.UInt64orUtf8inschema_for_kind. Evidence:crates/hevsearch-core/src/manager.rs.id_type; wrong-type upsert/import/delete rejects. Evidence:upsert,import_arrow_with_distance_metric,delete_ids.v1:u/v1:stokens with legacy numeric decode. Evidence:encode_list_cursor,decode_list_cursor, cursor unit tests.idasUInt64orUtf8, checked against existing namespaces. Evidence:validate_arrow_import_schema.RowId::to_sql_literalbeforeid IN (...). Evidence: string delete quote regression tests.validate_arrow_import_schematest withid: Utf8plusvectors.Open question for review:
Utf8ids or file a follow-up implementation issue for a concrete byte limit.Validation:
docs/rfcs/0005-arbitrary-row-ids.mdis the only touched file.git diff --checkpasses.