fix: Windows update checks no longer interrupt routine commands#1434
Conversation
Record failed optional dispatcher update attempts so routine commands do not retry the installer on every invocation. Suppress PowerShell progress output when invoking the Windows installer because redirected streams do not reliably hide host progress UI.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughFixes a bug where failed optional dispatcher self-updates weren't recorded, causing repeated retry attempts. Adds ChangesDispatcher self-update fix and Windows installer improvement
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
No issues found across 4 files
You’re at about 91% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Advance the dispatcher release version because this branch changes dispatcher release inputs. This satisfies the dispatcher version bump guard without changing the minimum dispatcher requirement for existing package installs.
Explain that dispatcher release input changes must advance cli/dispatcher-contract.json dispatcherVersion so future work does not miss the CI guard. Clarify that dispatcherContractVersion and minimumDispatcherVersion should only move when their contracts require it.
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
You’re at about 91% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Point contributors to the CI guard's authoritative dispatcher release input pattern list so the AGENTS guidance does not imply the example list is complete.
Summary
User Impact
Changes
Verification