Skip to content

chore: Keep release automation out of package notes#1440

Merged
hatayama merged 3 commits into
v3-betafrom
chore/release-pr-automation-scope
Jun 30, 2026
Merged

chore: Keep release automation out of package notes#1440
hatayama merged 3 commits into
v3-betafrom
chore/release-pr-automation-scope

Conversation

@hatayama

@hatayama hatayama commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • Keeps release PR automation changes out of the uloop-project-runner release notes.
  • Makes the release PR body normalizer wait for the pending release PR after release-please opens it.

User Impact

  • Release PR reviewers should no longer see release automation follow-ups listed as project runner fixes.
  • The Unity package section should be labeled once the release PR automation runs, instead of appearing as a bare version summary.

Changes

  • Excludes cli release automation paths from the project runner release component.
  • Runs release PR automation only when release-please reports that it created or updated PRs.
  • Retries pending release PR lookup to survive GitHub API propagation delay.
  • Removes the accidental fix: Release PRs label the Unity package summary #1438 entry from the project runner changelog.

Notes

Verification

  • go test ./internal/automation -run "ReleasePRCheck" -count=1
  • scripts/test-release-please-config.sh
  • ./scripts/check-go-cli.sh

Review in cubic

Exclude release PR automation paths from the project runner release component and retry release PR lookup after release-please opens a PR so body normalization can run despite GitHub API propagation delay.

Also correct the project runner changelog entry that accidentally included the release PR automation follow-up.
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1400f5cd-2744-4d5e-80ab-649acfe68e8c

📥 Commits

Reviewing files that changed from the base of the PR and between 37457f4 and 99defb4.

📒 Files selected for processing (4)
  • cli/internal/automation/release_pr_checks.go
  • cli/internal/automation/release_pr_checks_test.go
  • release-please-config.json
  • scripts/test-release-please-config.sh
📝 Walkthrough

Walkthrough

Adds findReleasePRCheckPullRequestWithRetry to retry the pending release PR lookup up to a configurable number of attempts. The CI workflow now also gates two automation steps on prs_created == 'true', and the cli release-please component excludes automation paths from scanning.

Changes

Release PR automation improvements

Layer / File(s) Summary
Retrying PR lookup
cli/internal/automation/release_pr_checks.go
findReleasePRCheckPullRequestWithRetry loops up to config.lookupAttempts times with config.lookupIntervalSeconds sleeps; RunReleasePleasePRChecks now calls this instead of the single-shot lookup.
Test harness and retry test
cli/internal/automation/release_pr_checks_test.go
releasePRCheckCase gains a lookupAttempts field; runReleasePRCheckCase sets RELEASE_PR_CHECK_LOOKUP_ATTEMPTS from it; TestReleasePRChecksRetryPendingReleasePRLookup exercises the retry path with an initially empty PR list.
Workflow guard, config exclusions, and validation
.github/workflows/release-please.yml, release-please-config.json, scripts/test-release-please-config.sh, cli/CHANGELOG.md
"Setup Go" and "Dispatch release PR checks" steps now also require prs_created == 'true'; cmd/dispatch-release-please-pr-checks and internal/automation are added to the cli component's exclude-paths; the config test script asserts both changes; one changelog bullet removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 37.50% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: excluding release automation from package notes/changelog.
Description check ✅ Passed The description accurately summarizes the workflow, retry logic, and changelog cleanup changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/release-pr-automation-scope

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@cli/internal/automation/release_pr_checks.go`:
- Around line 223-230: The retry loop in findReleasePRCheckPullRequestWithRetry
ignores cancellation during the backoff sleep, so update the sleep path to be
context-aware. In the attempt loop, replace the unconditional
releasePRCheckSleep call with a select on ctx.Done() versus a timer or
context-aware helper, and return ctx.Err() immediately when the context is
canceled or times out. Keep the existing retry behavior otherwise.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 306bf1f6-1d1e-4538-9689-57de52e8c8ee

📥 Commits

Reviewing files that changed from the base of the PR and between e8e87de and 37457f4.

📒 Files selected for processing (6)
  • .github/workflows/release-please.yml
  • cli/CHANGELOG.md
  • cli/internal/automation/release_pr_checks.go
  • cli/internal/automation/release_pr_checks_test.go
  • release-please-config.json
  • scripts/test-release-please-config.sh
💤 Files with no reviewable changes (1)
  • cli/CHANGELOG.md

Comment thread cli/internal/automation/release_pr_checks.go Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 6 files

You’re at about 92% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread release-please-config.json
Comment thread cli/internal/automation/release_pr_checks.go Outdated
Make release PR retry backoff context-aware so CI cancellation can stop the automation promptly, and cover the canceled lookup path in tests.
Make the project runner release exclusions match release-please file paths from the repository root so release automation changes are actually filtered out.
@hatayama hatayama merged commit cc236a8 into v3-beta Jun 30, 2026
10 checks passed
@hatayama hatayama deleted the chore/release-pr-automation-scope branch June 30, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant