fix: Dispatcher updates now show the installed version#1422
Conversation
Show the dispatcher version transition after successful automatic self-updates and manual update commands so users can tell which launcher version will run next.
|
Warning Review limit reached
More reviews will be available in 46 minutes and 11 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe PR adds helpers to read the installed dispatcher version and emit version-aware completion or error messages. Those helpers are wired into dispatcher freshness enforcement and manual update handling, with tests covering changed and unchanged version cases. ChangesDispatcher version-aware update output
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Advance the dispatcher contract version marker so the changed dispatcher launcher code can produce a new dispatcher release.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cli/internal/cli/dispatcher_update_version.go`:
- Around line 19-81: The dispatcher self-update code in
readInstalledDispatcherVersion and the related completion helpers is being
shipped without a version bump, so update the dispatcherVersion release input
used by this PR to a new value. Make the version increment consistent with the
rest of the dispatcher release plumbing so the updated behavior is published as
a distinct launcher build and CI can pass.
In `@cli/internal/cli/update_test.go`:
- Around line 194-230: The successful manual update tests in
tryHandleUpdateRequest only assert stdout content, so they miss accidental
status leakage to stderr. Tighten TestTryHandleUpdateRequestReportsVersionChange
and TestTryHandleUpdateRequestReportsAlreadyCurrentVersion to also verify stderr
remains empty after calling tryHandleUpdateRequest, using the existing stdout
and stderr buffers and the updateCommandName/manual update hook setup.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 96e58cfa-b0e2-41fd-bba6-8c8b7fb8c9d2
📒 Files selected for processing (5)
cli/internal/cli/dispatcher.gocli/internal/cli/dispatcher_test.gocli/internal/cli/dispatcher_update_version.gocli/internal/cli/update.gocli/internal/cli/update_test.go
There was a problem hiding this comment.
2 issues found and verified against the latest diff
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Normalize dispatcher update versions before comparison and reporting, and assert manual update success paths keep status output off stderr.
Summary
User Impact
Changes
uloop update.Verification
go test ./internal/cli -run 'TestEnforceDispatcherFreshness|TestTryHandleUpdateRequest'scripts/check-go-cli.shgit diff --check/Users/a12115/dotfiles/.claude/skills/autoreview/scripts/autoreview --mode branch --base origin/v3-beta