Skip to content

Remove encoding of HTML entities by the API #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
novasam23 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove encoding of HTML entities by the API #2296

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c41444
Change flag for HTML entity decoding to ENT_QUOTES to correspond with…
novasam23 Jul 2, 2026
97260d3
Remove encoding of HTML entities for strings entirely
novasam23 Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/inc/apiv2/common/AbstractBaseAPI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@ protected static function db2json(array $feature, mixed $val): mixed {
$obj = array_map('intval', preg_split("/,/", $val, -1, PREG_SPLIT_NO_EMPTY));
}
elseif (str_starts_with($feature['type'], 'str') && $val !== null) {
$obj = html_entity_decode($val, ENT_COMPAT, "UTF-8");
$obj = $val;
Comment thread
novasam23 marked this conversation as resolved.
}
else {
// TODO: Check all objects, instead of wild cast to hopefully-JSON compatible object
Comment thread
novasam23 marked this conversation as resolved.
Expand All @@ -632,7 +632,7 @@ protected static function json2db(array $feature, mixed $obj): ?string {
$val = $obj;
}
elseif (str_starts_with($feature['type'], 'str')) {
$val = htmlentities($obj, ENT_QUOTES, "UTF-8");
$val = $obj;
Comment thread
novasam23 marked this conversation as resolved.
}
elseif ($feature['type'] == 'array' && ($feature['subtype'] == 'int' || $feature['subtype'] == 'string')) {
$val = implode(",", $obj);
Expand Down
Loading