Remove encoding of HTML entities by the API#2296
Open
novasam23 wants to merge 2 commits into
Open
Conversation
… the flag used for encoding
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts API v2 database-to-JSON string decoding to decode both single and double quotes, aligning it with the existing DB encoding behavior and preventing malformed/incorrect config values (as described in #2278).
Changes:
- Update
html_entity_decode()flag fromENT_COMPATtoENT_QUOTESfor string-typed features indb2json().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
novasam23
changed the title
Member
|
Maybe it would make sense to write a pytest which tests creating and/or patching some object with some umlauts or other characters which would be affected by this htmlentities to verify for the future that it does not get added/changed by accident. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2278