Skip to content

chore(storage): remove TODOs to lift to shared bidi module #6750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsharonlynn merged 1 commit into from
Sep 10, 2026
Merged

chore(storage): remove TODOs to lift to shared bidi module #6750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/storage/src/storage/bidi_write/connector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// TODO(#5716): Lift to shared bidi module

use super::retry_redirect::RetryRedirect;
use super::state::AppendObjectSpecState;
use super::{Client, TonicStreaming};
Expand Down
2 changes: 0 additions & 2 deletions src/storage/src/storage/bidi_write/mocks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// TODO(#5716): Lift to shared bidi module.

use super::connector::Connector;
use super::tests::test_options;
use super::{Client, Receiver, RequestOptions, TonicStreaming};
Expand Down
2 changes: 0 additions & 2 deletions src/storage/src/storage/bidi_write/redirect.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// TODO(#5716): Lift to shared bidi module

use crate::Error;
use crate::google::rpc::Status as RpcStatus;
use crate::google::storage::v2::BidiWriteObjectRedirectedError;
Expand Down
2 changes: 0 additions & 2 deletions src/storage/src/storage/bidi_write/retry_redirect.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// TODO(#5716): Lift to shared bidi module

use super::redirect::is_redirect;
use google_cloud_gax::error::Error;
use google_cloud_gax::retry_policy::RetryPolicy;
Expand Down
2 changes: 0 additions & 2 deletions src/storage/src/storage/bidi_write/transport.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// TODO(#5716): Lift to shared bidi module

use super::coalescing_buffer::CoalescingBuffer;
use super::connector::{Connection, Connector};
use super::worker::{UploadIntent, Worker};
Expand Down
2 changes: 0 additions & 2 deletions src/storage/src/storage/bidi_write/worker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// TODO(#5716): Lift to shared bidi module

use super::connector::Connection;
use super::{Client, TonicStreaming};
use crate::Error;
Expand Down
Loading