chore(storage): remove TODOs to lift to shared bidi module - #6750
Open
vsharonlynn wants to merge 1 commit into
Open
chore(storage): remove TODOs to lift to shared bidi module#6750vsharonlynn wants to merge 1 commit into
vsharonlynn wants to merge 1 commit into
Conversation
Removes TODO(googleapis#5716) header comments in bidi_write. Bidi read and bidi write use distinct protobuf message and error types, follow different flow control patterns, and have different stability boundaries (read is stable, write is feature-gated). Abstracting them into a shared module introduces unnecessary complexity for minimal reuse. Cross-bidi refactoring can be evaluated independently from googleapis#5716.
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes obsolete TODO(#5716) comments regarding lifting code to a shared bidirectional streaming module across several files in the bidi_write storage module, including connector.rs, mocks.rs, redirect.rs, retry_redirect.rs, transport.rs, and worker.rs. I have no feedback to provide as there are no review comments to evaluate.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6750 +/- ##
==========================================
- Coverage 96.96% 96.95% -0.01%
==========================================
Files 319 319
Lines 105574 105574
==========================================
- Hits 102365 102363 -2
- Misses 3209 3211 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes TODO(#5716) header comments in bidi_write.
Bidi read and bidi write use distinct protobuf message and error types, follow different flow control patterns, and have different stability boundaries (read is stable, write is feature-gated). Abstracting them into a shared module introduces unnecessary complexity for minimal reuse. Cross-bidi refactoring can be evaluated independently from #5716.