Skip to content

Use GetFieldArrayElement in AccessPath and add SetValueNested mutation in serde_benchmark. #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −3
Open

Use GetFieldArrayElement in AccessPath and add SetValueNested mutation in serde_benchmark. #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions serde_json/serde_benchmark.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,13 +120,40 @@ void BM_SerdeJson_AccessPath(benchmark::State& state,
std::string json_document = LoadJson(json_file);
SerdeJson parsed = gtl::ValueOrDie(SerdeJson::Parse(json_document));
for (auto s : state) {
std::vector<SerdeJson> elements =
gtl::ValueOrDie(parsed.GetFieldArray("dataFeedElement"));
std::string name = gtl::ValueOrDie(elements[0].GetFieldString("name"));
SerdeJson data_feed_element =
gtl::ValueOrDie(parsed.GetFieldArrayElement("dataFeedElement", 0));
std::string name =
gtl::ValueOrDie(data_feed_element.GetFieldString("name"));
benchmark::DoNotOptimize(name);
}
}

void BM_Nlohmann_SetValueNested(benchmark::State& state,
absl::string_view json_file) {
std::string json_document = LoadJson(json_file);
nlohmann::json parsed = nlohmann::json::parse(json_document);
for (auto s : state) {
parsed["dataFeedElement"].push_back("name");
benchmark::DoNotOptimize(parsed);
parsed["dataFeedElement"].erase(parsed["dataFeedElement"].size() - 1);
}
}

void BM_SerdeJson_SetValueNested(benchmark::State& state,
absl::string_view json_file) {
std::string json_document = LoadJson(json_file);
SerdeJson parsed = gtl::ValueOrDie(SerdeJson::Parse(json_document));
SerdeJson name_val = gtl::ValueOrDie(SerdeJson::CreateString("name"));
for (auto s : state) {
std::vector<SerdeJson> array =
gtl::ValueOrDie(parsed.GetFieldArray("dataFeedElement"));
array.push_back(name_val);
benchmark::DoNotOptimize(parsed.AddFieldArray("dataFeedElement", array));
array.pop_back();
benchmark::DoNotOptimize(parsed.AddFieldArray("dataFeedElement", array));
}
}

[[maybe_unused]] const bool kBenchmarkRegistration = [] {
for (const auto& [benchmark_input_name, json_file] :
std::initializer_list<std::pair<absl::string_view, absl::string_view>>{
Expand All @@ -153,6 +180,10 @@ void BM_SerdeJson_AccessPath(benchmark::State& state,
BM_Nlohmann_AccessPath, "large.json");
benchmark::RegisterBenchmark("BM_SerdeJson_AccessPath_LargeDoc",
BM_SerdeJson_AccessPath, "large.json");
benchmark::RegisterBenchmark("BM_Nlohmann_SetValueNested_LargeDoc",
BM_Nlohmann_SetValueNested, "large.json");
benchmark::RegisterBenchmark("BM_SerdeJson_SetValueNested_LargeDoc",
BM_SerdeJson_SetValueNested, "large.json");
return false;
}();

Expand Down
Loading