Use GetFieldArrayElement in AccessPath and add SetValueNested mutation in serde_benchmark.#42
Open
copybara-service[bot] wants to merge 1 commit into
Open
Use GetFieldArrayElement in AccessPath and add SetValueNested mutation in serde_benchmark.#42copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_943741299
branch
2 times, most recently
from
df894bc to
72112f6
Compare
…n in serde_benchmark. The benchmark now uses GetFieldArrayElement to directly access the first element of the "dataFeedElement" array, instead of first getting the entire array. This shows the speed improvement of using the direct element accessor. It also now adds a benchmark of a mutation of a large json object by adding an element to the end of an internal array and then popping it. PiperOrigin-RevId: 943741299
copybara-service
Bot
force-pushed
the
test_943741299
branch
from
72112f6 to
fedb77d
Compare
copybara-service
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use GetFieldArrayElement in AccessPath and add SetValueNested mutation in serde_benchmark.
The benchmark now uses GetFieldArrayElement to directly access the first element of the "dataFeedElement" array, instead of first getting the entire array. This shows the speed improvement of using the direct element accessor.
It also now adds a benchmark of a mutation of a large json object by adding an element to the end of an internal array and then popping it.