Skip to content

Drop wall-clock assertions from TestPoolPerf #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umputun merged 1 commit into from
Aug 19, 2026
Merged

Drop wall-clock assertions from TestPoolPerf #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions bench_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,10 @@ func TestPoolPerf(t *testing.T) {
n := 1000
ctx := context.Background()

var egDuration time.Duration
t.Run("errgroup", func(t *testing.T) {
var count2 atomic.Int32
st := time.Now()
defer func() {
egDuration = time.Since(st)
t.Logf("elapsed errgroup: %v", time.Since(st))
}()
g, _ := errgroup.WithContext(ctx)
Expand Down Expand Up @@ -76,7 +74,6 @@ func TestPoolPerf(t *testing.T) {
require.NoError(t, p.Wait(ctx))
assert.Equal(t, int32(1000000), count1.Load())
t.Logf("elapsed pool: %v", time.Since(st))
assert.Less(t, time.Since(st), egDuration)
})

t.Run("pool with 100 chan size", func(t *testing.T) {
Expand All @@ -100,7 +97,6 @@ func TestPoolPerf(t *testing.T) {
require.NoError(t, p.Wait(ctx))
assert.Equal(t, int32(1000000), count1.Load())
t.Logf("elapsed pool: %v", time.Since(st))
assert.Less(t, time.Since(st), egDuration)
})

t.Run("pool with 100 chan size and 100 batch size", func(t *testing.T) {
Expand All @@ -124,7 +120,6 @@ func TestPoolPerf(t *testing.T) {
require.NoError(t, p.Wait(ctx))
assert.Equal(t, int32(1000000), count1.Load())
t.Logf("elapsed pool: %v", time.Since(st))
assert.Less(t, time.Since(st), egDuration)
})

t.Run("pool with 100 chan size and 100 batch size and chunking", func(t *testing.T) {
Expand All @@ -150,7 +145,6 @@ func TestPoolPerf(t *testing.T) {
require.NoError(t, p.Wait(ctx))
assert.Equal(t, int32(1000000), count1.Load())
t.Logf("elapsed pool: %v", time.Since(st))
assert.Less(t, time.Since(st), egDuration)
})

}
Expand Down