Drop wall-clock assertions from TestPoolPerf - #12
Merged
Conversation
each pool configuration was asserted to finish faster than a one-off errgroup baseline measured in the same run, which fails whenever the machine is loaded: seen locally at 3.71s against a 3.37s baseline, roughly one run in five. the timings are still logged, and BenchmarkPoolCompare already covers the comparison properly. the correctness assertions are untouched.
paskal
force-pushed
the
fix/flaky-perf-assertions
branch
from
August 19, 2026 05:37
3bfd977 to
8281a6a
Compare
umputun
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each pool configuration in
TestPoolPerfwas asserted to finish faster than a one-off errgroup baseline measured in the same run. That fails whenever the machine is loaded: locally it came in at 3.71s against a 3.37s baseline, roughly one run in five, and it is the same class of failure as an arbitrary sleep.The four
assert.Lesscalls and theegDurationvariable are removed. The elapsed times are still logged, the correctness assertions are untouched, andBenchmarkPoolComparealready covers the pool against errgroup comparison, which is where a wall-clock measurement belongs.