refactor(ec2): decouple creation result from control plane - #5312
Open
edersonbrilhante wants to merge 1 commit into
Open
refactor(ec2): decouple creation result from control plane#5312edersonbrilhante wants to merge 1 commit into
edersonbrilhante wants to merge 1 commit into
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
edersonbrilhante
force-pushed
the
refactor-ec2-orchestration-support
branch
2 times, most recently
from
August 27, 2026 20:15
c452fb1 to
6a5790d
Compare
edersonbrilhante
changed the title
edersonbrilhante
force-pushed
the
refactor-ec2-orchestration-support
branch
from
August 27, 2026 20:35
6a5790d to
3179711
Compare
edersonbrilhante
changed the title
edersonbrilhante
marked this pull request as ready for review
August 27, 2026 20:44
edersonbrilhante
force-pushed
the
refactor-ec2-orchestration-support
branch
from
August 27, 2026 21:00
3179711 to
0d1969f
Compare
edersonbrilhante
force-pushed
the
refactor-ec2-orchestration-support
branch
from
August 28, 2026 11:03
0d1969f to
f990720
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Separates the result returned by shared EC2 runner creation from the control-plane
CreateRunnerResultcontract.createEc2Runner()andEc2RunnerResourceOperations.create()now returnEc2RunnerCreateResult, containing created instance IDs, the failed-instance count, and bounded AWS failure identifiers.The control-plane adapter converts that result into its existing
CreateRunnerResultand applies retryable or non-retryable classification usingscaleErrors. The core contract and existing pool and scale-up behavior remain unchanged.Test Plan
git diff --checkand pre-commit checks passed.Related Issues
Depends on #5301.