feat(scale-set): add service controller - #5300
Draft
edersonbrilhante wants to merge 19 commits into
Draft
Conversation
Contributor
Dependency ReviewThe following issues were found:
License Issueslambdas/services/scale-set/package.json
OpenSSF ScorecardScorecard details
Scanned Files
|
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
August 26, 2026 11:49
341697e to
3eb2808
Compare
edersonbrilhante
changed the base branch from
refactor-ec2-provider-isolation
to
refactor-ec2-runner-orchestration-boundary
August 26, 2026 11:49
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
August 26, 2026 12:43
3eb2808 to
9e47723
Compare
edersonbrilhante
marked this pull request as draft
August 26, 2026 13:59
edersonbrilhante
force-pushed
the
refactor-ec2-runner-orchestration-boundary
branch
3 times, most recently
from
August 27, 2026 11:50
af43f2b to
e8f4188
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
August 27, 2026 12:20
6ac6290 to
46d0cd5
Compare
edersonbrilhante
changed the base branch from
refactor-ec2-runner-orchestration-boundary
to
refactor-pool-provider-test-boundary
August 27, 2026 12:22
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
August 27, 2026 19:00
acf9a55 to
86ecd3a
Compare
edersonbrilhante
changed the base branch from
refactor-pool-provider-test-boundary
to
refactor-ec2-runner-orchestration-boundary
August 27, 2026 19:00
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
August 27, 2026 19:28
86ecd3a to
98e3f72
Compare
edersonbrilhante
changed the base branch from
refactor-ec2-runner-orchestration-boundary
to
refactor-ec2-orchestration-support
August 27, 2026 19:28
edersonbrilhante
force-pushed
the
refactor-ec2-orchestration-support
branch
from
August 27, 2026 19:59
081e6bf to
c452fb1
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
August 27, 2026 19:59
98e3f72 to
1ace218
Compare
edersonbrilhante
force-pushed
the
refactor-ec2-orchestration-support
branch
from
August 27, 2026 20:15
c452fb1 to
6a5790d
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
August 27, 2026 20:15
1ace218 to
dec0ffa
Compare
edersonbrilhante
force-pushed
the
refactor-ec2-orchestration-support
branch
from
August 27, 2026 20:35
6a5790d to
3179711
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
August 27, 2026 20:35
dec0ffa to
652dba7
Compare
edersonbrilhante
force-pushed
the
refactor-ec2-orchestration-support
branch
2 times, most recently
from
August 28, 2026 11:03
0d1969f to
f990720
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
August 28, 2026 11:13
652dba7 to
fb95b1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the scale-set service controller, GitHub scale-set client library, EC2 scale-set capability, and container build and release workflow.
Builds on the neutral EC2 runner creation result from #5312. This PR owns the scale-set-specific orchestration tags and their validation, adds the explicit
scale-set-servicerunner source, and binds each reconciliation request's abort signal before launch, tag, or terminate work.Splits the EC2 scale-set logic into configuration, inventory, reconciliation, scale-up, and scale-down contexts, with
provider.tsas the public facade and matching context-focused tests.Aligns message handling with the upstream actions/scaleset listener: acknowledge before job acquisition and reconciliation, treat provider failures after acknowledgement as fatal for that reconciler, and keep transport and session recovery separate. Scale-set consumes neutral failed-instance counts and does not inherit the webhook/SQS retry policy.
Normalizes GitHub and Actions service URL paths with linear scans, avoiding regular-expression denial-of-service risks on uncontrolled input while preserving invalid-path rejection.
Test Plan
git diff --checkand pre-commit checks passed.Related Issues
Depends on #5312.