Skip to content

fix(exports): add new variable row height to Excel/PDF Export Services - #2677

Merged
ghiscoding merged 2 commits into
masterfrom
refactor/export-variable-row-height
Jul 29, 2026
Merged

fix(exports): add new variable row height to Excel/PDF Export Services#2677
ghiscoding merged 2 commits into
masterfrom
refactor/export-variable-row-height

Conversation

@ghiscoding

Copy link
Copy Markdown
Owner

When we added variable row height in previous PR #2650 , I forgot to add it to the Excel/PDF export services. It might not always be useful though, so I also added a flag in case the user wants to disable it in the exports

const gridOptions: GridOption = {
  enableVariableRowHeight: true,
  excelExportOptions: {
    includeVariableRowHeight: false, // skip variable heights in Excel export
  },
  pdfExportOptions: {
    includeVariableRowHeight: false, // skip variable heights in PDF export
  },
};

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (15d9833) to head (a404f33).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2677   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         200      200           
  Lines       25452    25469   +17     
  Branches     8999     9007    +8     
=======================================
+ Hits        25452    25469   +17     
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Jul 29, 2026

Copy link
Copy Markdown
angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2677

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2677

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2677

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2677

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2677

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2677

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2677

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2677

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2677

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2677

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2677

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2677

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2677

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2677

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2677

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2677

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2677

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2677

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2677

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2677

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2677

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2677

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2677

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2677

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2677

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2677

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2677

@slickgrid-universal/web-mcp

npm i https://pkg.pr.new/@slickgrid-universal/web-mcp@2677

commit: a404f33

@ghiscoding
ghiscoding merged commit 66d8876 into master Jul 29, 2026
22 checks passed
@ghiscoding
ghiscoding deleted the refactor/export-variable-row-height branch July 29, 2026 16:46
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🎉 This pull request is included in version 10.9.0 📦
🔗 The release notes are available at: GitHub Release 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant