Skip to content

perf(export): optimize Excel/PDF export variable row height handling - #2681

Merged
ghiscoding merged 2 commits into
masterfrom
perf/excel-variable-row-height
Jul 30, 2026
Merged

perf(export): optimize Excel/PDF export variable row height handling#2681
ghiscoding merged 2 commits into
masterfrom
perf/excel-variable-row-height

Conversation

@ghiscoding

@ghiscoding ghiscoding commented Jul 30, 2026

Copy link
Copy Markdown
Owner

follow-up of PR #2677 to improve perfs

Excel export now applies variable row heights during the existing row serialization pass instead of doing a second worksheet-wide traversal afterward. The change also skips emitting row instructions for rows that still use the default grid row height, which reduces unnecessary work and output size for large datasets while preserving exported row height fidelity for rows that actually differ.

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (4adb63f) to head (74435f6).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2681   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         200      200           
  Lines       25469    25480   +11     
  Branches     9007     9006    -1     
=======================================
+ Hits        25469    25480   +11     
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Jul 30, 2026

Copy link
Copy Markdown
angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2681

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2681

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2681

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2681

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2681

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2681

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2681

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2681

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2681

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2681

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2681

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2681

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2681

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2681

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2681

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2681

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2681

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2681

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2681

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2681

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2681

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2681

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2681

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2681

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2681

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2681

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2681

@slickgrid-universal/web-mcp

npm i https://pkg.pr.new/@slickgrid-universal/web-mcp@2681

commit: 74435f6

@ghiscoding
ghiscoding merged commit ebf49f2 into master Jul 30, 2026
14 checks passed
@ghiscoding
ghiscoding deleted the perf/excel-variable-row-height branch July 30, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant