Repository navigation
Conversation
…on middleware The fetch wrapper detected server functions by URL and started a span with a placeholder name that the function middleware renamed later. The middleware receives the function metadata, so it now creates the span itself. This also covers server functions called during SSR or from another server function. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Member
Author
|
bugbot run |
Contributor
size-limit report 📦Compared: 6522a05 (PR test merge using develop at 9b7265f) Against: 9b7265f (develop) · base run #66464 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsAll optional checks were successful. 3 successful. See the run. Successful checks
|
…assertions Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b4cf9bb. Configure here.
chargome
marked this pull request as ready for review
November 17, 2026 13:39
javascript-sdk-gitflow
Bot
requested review from
nicohrubec,
s1gr1d and
timfish
November 17, 2026 13:39
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sentryGlobalFunctionMiddlewarenow creates the server function span. Server functions called during SSR or from another server function get a span automatically, and a span gets an error status when its function throws.The span now only measures the function and its function middlewares, not the request middlewares and the (de)serialization around it.
Why
wrapFetchWithSentrydetected server functions by URL, started a span with a placeholder name, and the middleware renamed it later. The function middleware already receives the function's metadata, so it can create the span directly with less code. Part of #26022.