Skip to content

ref(tanstackstart-react): Use code.file.path on server function spans - #26495

Open
chargome wants to merge 1 commit into
feat/tanstackstart-serverfn-span-in-middlewarefrom
ref/tanstackstart-serverfn-span-conventions
Open

chargome wants to merge 1 commit into
feat/tanstackstart-serverfn-span-in-middlewarefrom
ref/tanstackstart-serverfn-span-conventions

Conversation

@chargome

@chargome chargome commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

What

Server function spans now set code.file.path instead of tanstackstart.function.filename. The tanstackstart.function.id attribute is removed.

Why

Neither attribute is in @sentry/conventions. The file name has a standard attribute, and the span already uses code.function.name. The id is a hash that Start generates at build time, so it is not useful for querying. Doing this before the SDK is marked stable avoids renaming attributes later.

Replace the custom `tanstackstart.function.filename` attribute with the
standard `code.file.path` and drop `tanstackstart.function.id`, which is
a build-time hash without a convention.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@chargome chargome self-assigned this Nov 17, 2026
@chargome

Copy link
Copy Markdown
Member Author

bugbot run

@linear-code

linear-code Bot commented Nov 17, 2026

Copy link
Copy Markdown

JSSDK-56

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit e796b7a. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: d64f102 (PR test merge using feat/tanstackstart-serverfn-span-in-middleware at b4cf9bb)

Against: d586a5d (feat/tanstackstart-serverfn-span-in-middleware) · base run #66409

⚠️ Baseline mismatch: 2 feat/tanstackstart-serverfn-span-in-middleware commit(s) in the PR build are missing from the baseline. Their size changes also affect this comparison. Compare commits. Re-run once feat/tanstackstart-serverfn-span-in-middleware's baseline build for b4cf9bb finishes.

Path Size % Change Change
@sentry/browser 30.1 kB - -
@sentry/browser - with treeshaking flags 28.3 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 28.2 kB - -
@sentry/browser (incl. Tracing) 52.28 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 52.29 kB - -
@sentry/browser (incl. Tracing, Profiling) 55.25 kB - -
@sentry/browser (incl. Tracing, Replay) 92.82 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.6 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 97.21 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 110.6 kB - -
@sentry/browser (incl. Feedback) 47.73 kB - -
@sentry/browser (incl. sendFeedback) 30.69 kB - -
@sentry/browser (incl. FeedbackAsync) 35.69 kB - -
@sentry/browser (incl. Metrics) 31.43 kB - -
@sentry/browser (incl. Logs) 31.71 kB - -
@sentry/browser (incl. Metrics & Logs) 32.37 kB - -
@sentry/react 32.11 kB - -
@sentry/react (incl. Tracing) 54.95 kB - -
@sentry/vue 38.29 kB - -
@sentry/vue (incl. Tracing) 55.24 kB - -
@sentry/svelte 30.12 kB - -
@sentry/remix (Remix 3 client bundle) 58.06 kB - -
CDN Bundle 31.87 kB - -
CDN Bundle (incl. Tracing) 52.7 kB - -
CDN Bundle (incl. Logs, Metrics) 34.67 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 55.26 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 75.7 kB - -
CDN Bundle (incl. Tracing, Replay) 90.72 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.33 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 96.09 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.69 kB - -
CDN Bundle - uncompressed 92.98 kB - -
CDN Bundle (incl. Tracing) - uncompressed 155.45 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.33 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 163.08 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 231.44 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 275.61 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 283.24 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.4 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 295.02 kB - -
@sentry/nextjs (client) 58.57 kB - -
@sentry/sveltekit (client) 53.57 kB - -
@sentry/core/server 44.8 kB - -
@sentry/core/browser 14.4 kB - -
@sentry/node 151.36 kB -0.01% -6 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.3 kB - -
@sentry/node - without tracing 88.56 kB -0.01% -6 B 🔽
@sentry/node - without channel injection 140.3 kB -0.01% -6 B 🔽
@sentry/aws-serverless 98.93 kB -0.01% -7 B 🔽
@sentry/cloudflare (withSentry) - minified 206.47 kB - -
@sentry/cloudflare (withSentry) 479.22 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 231.83 kB - -

View base workflow run

@github-actions

Copy link
Copy Markdown
Contributor

Optional E2E tests

All optional checks were successful. 3 successful. See the run.

Successful checks
Check Status
✅ CI: Optional E2E Tests / E2E tanstackstart-react-sourcemaps Test (optional) Successful in 32s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-cloudflare Test (optional) Successful in 46s Details

@chargome
chargome added this pull request to stack #26496 November 17, 2026 15:45
@chargome
chargome marked this pull request as ready for review November 17, 2026 15:46

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant