Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/actions/install-playwright/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,14 @@ runs:
install -y --no-install-recommends "${packages[@]}"
shell: bash

# Before a launch, Playwright also checks the libraries of the GTK executable, which headless tests do not start
# and the list above does not have. Without this, a launch only works while the browser cache holds Playwright's
# `DEPENDENCIES_VALIDATED` marker, which expires after 30 days.
- name: Skip Playwright's host validation
if: steps.webkit-dependencies.outputs.key != ''
run: echo "PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS=1" >> "$GITHUB_ENV"
shell: bash

- name: Remove obsolete cached WebKit packages
if:
steps.webkit-dependencies.outputs.key != '' && steps.webkit-apt-cache.outputs.cache-hit != 'true' &&
Expand Down
13 changes: 10 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ jobs:
job_check_lockfile:
name: Check lockfile
needs: [job_get_metadata]
# `pnpm dedupe --check` fetches metadata for every package from npm, so this job can take 8+ min on PRs.
# `pnpm dedupe` fetches metadata for every package from npm, so this job can take 8+ min on PRs.
timeout-minutes: 20
runs-on: ubuntu-24.04
if: |
Expand All @@ -371,14 +371,21 @@ jobs:
uses: ./.github/actions/setup-node
- name: Install dependencies
run: pnpm install --no-frozen-lockfile
# The lockfile stores the deprecation message of each package. A maintainer can deprecate a locked version on
# npm at any time, which changes the lockfile without a change in this repository. Both checks ignore these lines.
- name: Check that pnpm-lock.yaml is stable
run: |
if ! git diff --exit-code pnpm-lock.yaml; then
if ! git diff --exit-code -I'^ +deprecated: ' pnpm-lock.yaml; then
echo "::error::pnpm-lock.yaml has uncommitted changes after running 'pnpm install'. Please run 'pnpm install' locally and commit the updated pnpm-lock.yaml."
exit 1
fi
- name: Check for duplicate dependencies in lockfile
run: pnpm run dedupe-deps:check
run: |
pnpm dedupe --lockfile-only
if ! git diff --exit-code -I'^ +deprecated: ' pnpm-lock.yaml; then
echo "::error::pnpm-lock.yaml has duplicate dependencies. Please run 'pnpm run dedupe-deps:fix' locally and commit the updated pnpm-lock.yaml."
exit 1
fi

job_check_format:
name: Check file formatting
Expand Down
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ packages/gatsby/gatsby-node.d.ts
*.iml
/**/.wrangler/*

#junit reports
packages/**/*.junit.xml

# Local Claude Code settings that should not be committed
.claude/settings.local.json
Expand Down
3 changes: 0 additions & 3 deletions dev-packages/bun-integration-tests/vite.config.mts
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ export default defineConfig({
...baseConfig,
test: {
...baseConfig.test,
coverage: {
enabled: false,
},
isolate: false,
testTimeout: 20_000,
...(process.env.DEBUG
Expand Down
3 changes: 0 additions & 3 deletions dev-packages/cloudflare-integration-tests/vite.config.mts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ export default defineConfig({
...baseConfig,
test: {
...baseConfig.test,
coverage: {
enabled: false,
},
isolate: false,
include: ['./suites/**/test.ts'],
// Each test spawns its own `wrangler dev` (cold workerd boot) and waits for envelopes to be
Expand Down
3 changes: 0 additions & 3 deletions dev-packages/deno-integration-tests/vite.config.mts
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ export default defineConfig({
test: {
...baseConfig.test,
root: fileURLToPath(new URL('../node-integration-tests', import.meta.url)),
coverage: {
enabled: false,
},
isolate: false,
include: ['suites/**/test.ts'],
exclude: NODE_SUITES_EXCLUDE,
Expand Down
3 changes: 0 additions & 3 deletions dev-packages/node-integration-tests/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ export default defineConfig({
test: {
...baseConfig.test,
isolate: false,
coverage: {
enabled: false,
},
include: ['./**/test.ts'],
testTimeout: 15000,
// Ensure we can see debug output when DEBUG=true
Expand Down
7 changes: 0 additions & 7 deletions vite/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export default defineConfig({
},
test: {
coverage: {
enabled: true,
reportsDirectory: './coverage',
exclude: [
'**/node_modules/**',
Expand All @@ -35,12 +34,6 @@ export default defineConfig({
'vite.config.*',
],
},
reporters: process.env.CI
? ['default', 'github-actions', ['junit', { classnameTemplate: '{filepath}' }]]
: ['default'],
outputFile: {
junit: 'vitest.junit.xml',
},
typecheck: {
tsconfig: './tsconfig.test.json',
},
Expand Down
Loading