Repository navigation
ci: Fix the lockfile check, the WebKit launch, and slow unit tests - #26458
Merged
Merged
Conversation
The lockfile stores the deprecation message of each package. When a maintainer deprecates a locked version on npm, `pnpm install` and `pnpm dedupe --check` want to add that line. The check then failed on develop without a change in the repository, in 19 runs in one month. Both steps now compare the lockfile with `git diff -I` and ignore these lines.
The action installs only the libraries of the headless WebKit executable. Before a launch, Playwright validates the libraries of all WebKit executables, unless the browser directory holds a `DEPENDENCIES_VALIDATED` marker that is younger than 30 days. The cached browsers hold a marker from 2026-11-04. WebKit jobs passed only with a cache hit, and all of them would fail from 2026-12-04.
No workflow reads the coverage or junit output since Codecov was removed (#20803). Coverage makes the unit tests of `@sentry/core` about three times slower (66 s against 24 s locally), which pushes slow tests over their timeout on a busy CI runner. Vitest adds the `github-actions` reporter by itself, so the CI annotations stay. Use `vitest --coverage` to collect coverage.
Contributor
size-limit report 📦Compared: 16f47a6 (PR test merge using develop at 1d3a542) Against: 1d3a542 (develop) · base run #66400 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 62 successful. See the run.
Successful checks
|
s1gr1d
marked this pull request as ready for review
November 17, 2026 12:48
javascript-sdk-gitflow
Bot
requested review from
JPeer264,
andreiborza and
isaacs
November 17, 2026 12:49
nicohrubec
approved these changes
Nov 17, 2026
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
deprecated:lines inpnpm-lock.yaml.vitest --coverageto collect coverage.Why
I went through the CI logs of the last month (601
developruns, 294 of them not green). These three causes are not in test code:deprecated:line to the lockfile. "Check lockfile" then failed ondevelopwithout a change in the repo, in 19 runs, until someone committed the line.DEPENDENCIES_VALIDATEDmarker, which is valid for 30 days. The cache is from 2026-11-04, so all WebKit jobs would fail from 2026-12-04. Jobs with a failed cache restore failed already on 11-16 and 11-17. The action installs only the libraries that headless WebKit needs, so the full validation cannot pass.@sentry/coretests about 3x slower (66 s against 24 s locally), and slow unit tests timed out on busy runners. Vitest adds thegithub-actionsreporter by itself, so the annotations stay.pnpm run dedupe-deps:checkstill fails on a new deprecation, because I did not changepackage.json. The WebKit change needs a CI job without the cached marker to prove it.First PR of a stack of four.