Repository navigation
fix(server-utils): Mark Mistral and Workers AI spans as cancelled when the caller aborts - #26454
Merged
Merged
Conversation
…n the caller aborts Co-Authored-By: Rola Abuhasna <rola.abuhasna@sentry.io>
Contributor
size-limit report 📦Compared: 848bb58 (PR test merge using develop at 1d3a542) Against: 1d3a542 (develop) · base run #66400 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 3 not successful, 58 successful. See the run.
Successful checks
|
…hen the caller aborts mid-stream Co-Authored-By: Rola Abuhasna <rola.abuhasna@sentry.io>
Co-Authored-By: Rola Abuhasna <rola.abuhasna@sentry.io>
RulaKhaled
marked this pull request as ready for review
November 17, 2026 10:47
javascript-sdk-gitflow
Bot
requested review from
andreiborza,
isaacs and
timfish
November 17, 2026 10:47
nicohrubec
pushed a commit
that referenced
this pull request
Nov 17, 2026
…26463) ## What A contractor who hasn't linked GitHub in Junior is now resolved from their Slack name, so Junior PRs they request no longer get the `Waiting for: Team Review` label or get routed back to them for review. ## Why Before, names were only matched against `team-javascript-sdks` members, while trust is checked against the team plus `CONTRACTORS`. Contractors can't be team members, so their names never resolved and their own PRs were gated (for example #26454). Names are now matched against the same trusted set, so a name still can't resolve to an untrusted user. <!-- junior-request-attribution:start --> via **Rola Abuhasna**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AD0C848BQ509%3A1794828511.487889 --> -- [View Session](https://junior-prod.sentry.dev/conversations/slack%3AD0C848BQ509%3A1794828511.487889) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AD0C848BQ509%3A1794828511.487889/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Rola Abuhasna <rola.abuhasna@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
If the caller aborts a Mistral or Workers AI call, the span now ends as
cancelledinstead ofinternal_error. This covers streaming and non-streaming calls, aborts mid-stream, and, for Mistral, both the client wrapper and the Orchestrion path. SDK timeouts and a caller's ownAbortSignal.timeout()still end as errors.Why
The rule: if the request or stream errors and the caller's signal fired, the span is
cancelled. OpenAI and Anthropic stay out of the mid-stream part, because their SDKs end the stream quietly on abort, so there's no error to classify.Closes: #26130
via Rola Abuhasna.
--
View Session [Sentry]