Repository navigation
ci: Resolve contractors' Slack names in the Junior requester lookup - #26463
Merged
Merged
Conversation
Co-Authored-By: Rola Abuhasna <rola.abuhasna@sentry.io>
RulaKhaled
marked this pull request as ready for review
November 17, 2026 11:04
javascript-sdk-gitflow
Bot
requested review from
RulaKhaled,
logaretm and
timfish
November 17, 2026 11:04
Contributor
size-limit report 📦Compared: c1d46ab (PR test merge using develop at d586a5d) Against: d586a5d (develop) · base run #66409 ✅ Baseline matches: this diff contains only this PR's changes.
|
nicohrubec
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A contractor who hasn't linked GitHub in Junior is now resolved from their Slack name, so Junior PRs they request no longer get the
Waiting for: Team Reviewlabel or get routed back to them for review.Why
Before, names were only matched against
team-javascript-sdksmembers, while trust is checked against the team plusCONTRACTORS. Contractors can't be team members, so their names never resolved and their own PRs were gated (for example #26454). Names are now matched against the same trusted set, so a name still can't resolve to an untrusted user.via Rola Abuhasna.
--
View Session [Sentry]