Repository navigation
Conversation
Match the island segment by its referer so a segment from another test cannot satisfy the assertions, and drop the test that checked Chromium's preload reuse rather than SDK behavior. Refs JSSDK-38 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦Compared: 55d2f25 (PR test merge using develop at cfb15f1) Against: cfb15f1 (develop) · base run #66383 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsAll optional checks were successful. 1 successful. See the run. Successful checks
|
chargome
marked this pull request as ready for review
November 17, 2026 09:52
javascript-sdk-gitflow
Bot
requested review from
RulaKhaled,
nicohrubec and
s1gr1d
November 17, 2026 09:53
RulaKhaled
reviewed
Nov 17, 2026
| 'http.request.header.user-agent': { value: [expect.any(String)], type: 'array' }, | ||
| }); | ||
|
|
||
| // unfortunately, the server island trace id is not the same as the client pageload trace id |
Collaborator
There was a problem hiding this comment.
the comment still says the fetch instrumentation can't attach headers, which contradicts the new one in the SSR test. worth aligning while you're in here
RulaKhaled
approved these changes
Nov 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #26405 from review: the island span is matched by its referer, so a span from another test can't satisfy the assertions, and the test that checked Chromium's preload reuse is removed.
Why
The old matcher accepted any island span, so the SSR assertion couldn't fail. The preload test covered browser behavior, not the SDK.
Linear: JSSDK-38
🤖 Generated with Claude Code