Skip to content

feat(astro): Mark pageloads of prerendered pages - #26453

Open
chargome wants to merge 2 commits into
test/astro-server-islands-e2e-fixesfrom
feat/astro-server-islands-pageload-marker
Open

chargome wants to merge 2 commits into
test/astro-server-islands-e2e-fixesfrom
feat/astro-server-islands-pageload-marker

Conversation

@chargome

Copy link
Copy Markdown
Member

What

Pageloads of prerendered Astro pages, including server-island shells, get page.server_rendering.type: static, using the shared sentry-cache-origin helpers like Next.js, Nuxt and SvelteKit.

Why

These pageloads have no server span, so they looked like missing server instrumentation. Server-island shells are static, not partially_static: the islands render in separate requests, not in the same response. There is no link to the render because the build sends no spans. Prerendering is now detected with ctx.isPrerendered (Astro 5+), so on-demand pages on adapters without a client address are no longer treated as prerendered.

Stacked on #26452.

Linear: JSSDK-38

🤖 Generated with Claude Code

A prerendered page now gets an empty sentry-cache-origin meta tag, so its pageload gets
page.server_rendering.type: static instead of looking like it lacks server instrumentation.
Prerendering is detected with ctx.isPrerendered on Astro 5+, so on-demand pages on adapters
without a client address are no longer treated as prerendered.

Refs JSSDK-38
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chargome chargome self-assigned this Nov 17, 2026
Use the renamed _INTERNAL_getCacheOriginMetaTags, which also writes sentry-render-start, so
the pageload gets page.server_rendering.age like Next.js, Nuxt and SvelteKit.

Refs JSSDK-38
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: 85c77d7 (PR test merge using test/astro-server-islands-e2e-fixes at 3045202)

Against: cfb15f1 (test/astro-server-islands-e2e-fixes) · base run #66383

⚠️ Baseline mismatch: 1 test/astro-server-islands-e2e-fixes commit(s) in the PR build are missing from the baseline. Their size changes also affect this comparison. Compare commits. Re-run once test/astro-server-islands-e2e-fixes's baseline build for 3045202 finishes.

Path Size % Change Change
@sentry/browser 30.1 kB - -
@sentry/browser - with treeshaking flags 28.3 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 28.2 kB - -
@sentry/browser (incl. Tracing) 52.28 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 52.29 kB - -
@sentry/browser (incl. Tracing, Profiling) 55.25 kB - -
@sentry/browser (incl. Tracing, Replay) 92.82 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.6 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 97.21 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 110.6 kB - -
@sentry/browser (incl. Feedback) 47.73 kB - -
@sentry/browser (incl. sendFeedback) 30.69 kB - -
@sentry/browser (incl. FeedbackAsync) 35.69 kB - -
@sentry/browser (incl. Metrics) 31.43 kB - -
@sentry/browser (incl. Logs) 31.71 kB - -
@sentry/browser (incl. Metrics & Logs) 32.37 kB - -
@sentry/react 32.11 kB - -
@sentry/react (incl. Tracing) 54.95 kB - -
@sentry/vue 38.29 kB - -
@sentry/vue (incl. Tracing) 55.24 kB - -
@sentry/svelte 30.12 kB - -
@sentry/remix (Remix 3 client bundle) 58.06 kB - -
CDN Bundle 31.87 kB - -
CDN Bundle (incl. Tracing) 52.7 kB - -
CDN Bundle (incl. Logs, Metrics) 34.67 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 55.26 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 75.7 kB - -
CDN Bundle (incl. Tracing, Replay) 90.72 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.33 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 96.09 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.69 kB - -
CDN Bundle - uncompressed 92.98 kB - -
CDN Bundle (incl. Tracing) - uncompressed 155.45 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.33 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 163.08 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 231.44 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 275.61 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 283.24 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.4 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 295.02 kB - -
@sentry/nextjs (client) 58.57 kB - -
@sentry/sveltekit (client) 53.57 kB - -
@sentry/core/server 44.8 kB - -
@sentry/core/browser 14.4 kB - -
@sentry/node 151.35 kB -0.01% -7 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.3 kB - -
@sentry/node - without tracing 88.56 kB -0.01% -5 B 🔽
@sentry/node - without channel injection 140.3 kB -0.01% -5 B 🔽
@sentry/aws-serverless 98.93 kB -0.01% -6 B 🔽
@sentry/cloudflare (withSentry) - minified 206.47 kB - -
@sentry/cloudflare (withSentry) 479.22 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 231.83 kB - -

View base workflow run

@github-actions

Copy link
Copy Markdown
Contributor

Optional E2E tests

All optional checks were successful. 2 successful. See the run.

Successful checks
Check Status
✅ CI: Optional E2E Tests / E2E astro-7 Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E astro-7-static Test (optional) Successful in 1m Details

@chargome
chargome added this pull request to stack #26455 November 17, 2026 09:51
@chargome
chargome marked this pull request as ready for review November 17, 2026 09:55

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant