Skip to content

feat(names): Add FAAS function span name and description rules #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 2 commits into from
Sep 3, 2026
+25 −0
Merged

feat(names): Add FAAS function span name and description rules #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2620e5b
feat(names): Add FAAS function span name and description rules
Lms24 Sep 3, 2026
17ad143
Merge branch 'main' into lms/feat-faas-desc-names
Lms24 Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions model/description/faas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"brief": "Serverless (FAAS)",
"operations": [
{
"name": "Serverless function execution",
"brief": "The invocation of a serverless function on a cloud provider.",
"ops": ["function.aws", "function.gcp", "function.azure"],
"templates": ["{{faas.name}}"],
"examples": ["my_function", "process-upload"]
}
]
}
13 changes: 13 additions & 0 deletions model/name/faas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"brief": "Serverless (FAAS)",
"operations": [
{
"name": "Serverless function execution",
"brief": "The invocation of a serverless function on a cloud provider.",
"is_in_otel": false,
"ops": ["function.aws", "function.gcp", "function.azure"],

@cursor cursor Bot Sep 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rules omit production FAAS ops

Medium Severity

The new name and description rules list function.aws, function.gcp, and function.azure, but Sentry SDKs emit function.aws.lambda for AWS Lambda invocations. Relay matches ops exactly, so those spans will not receive faas.name-based names or descriptions.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2620e5b. Configure here.

@Lms24 Lms24 Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically correct but: this op is not registered in conventions and it's no longer sent by the JS SDK in v11 (function.aws is sent instead). I think it's fine to omit for now. I might add it later once #622 lands so that we could theoretically add an op as deprecated and then use it here.

"templates": ["{{faas.name}}", "Serverless function execution"],
"examples": ["my_function", "process-upload", "Serverless function execution"]
}
]
}
Loading