Skip to content

feat(names): Add FAAS function span name and description rules - #617

Merged
Lms24 merged 2 commits into
mainfrom
lms/feat-faas-desc-names
Sep 3, 2026
Merged

feat(names): Add FAAS function span name and description rules#617
Lms24 merged 2 commits into
mainfrom
lms/feat-faas-desc-names

Conversation

@Lms24

@Lms24 Lms24 commented Sep 3, 2026

Copy link
Copy Markdown
Member

Description

Adds serverless function execution span (function.(aws|gcp|azure)) name and description rules, relying on the faas.name attribute

ref: getsentry/sentry-javascript#23954

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate to generate and format code and docs.

If an attribute was added:

  • The attribute is in a namespace (e.g. nextjs.function_id, not function_id)
  • I have used the correct value for apply_scrubbing (i.e. manual or auto. Use never only for values that should never be scrubbed such as IDs)

If an attribute was deprecated:

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add sveltekit.* attributes emitted by SvelteKit's native spans by Lms24 in #611
  • Add browser.navigation.type, move navigation.* to router.navigation.* by logaretm in #600
  • Add langchain.chain.name (deprecated) in favor of gen_ai.pipeline.name by RulaKhaled in #599
  • Add browser.paint.type by Lms24 in #606

Names

  • Add FAAS function span name and description rules by Lms24 in #617
  • Add function span name and description rules by Lms24 in #618
  • Add browser.* span name and description rules by Lms24 in #607
  • Add cache span name rules by Lms24 in #605

Other

  • (descriptions) Add graphql span description rules by Lms24 in #616

Bug Fixes 🐛

  • (descriptions) Add graphql-enhanced http.client span description template by Lms24 in #613

Internal Changes 🔧

Deps

  • Bump browserslist from 4.28.2 to 4.28.8 by dependabot in #614
  • Bump fast-uri from 3.1.5 to 3.1.7 by dependabot in #612

Other

  • (descriptions) Fix http.client span description example by Lms24 in #603
  • (names) Add OTel divergence note for graphql span names by Lms24 in #615

🤖 This preview updates automatically when you update the PR.

@Lms24

Lms24 commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

bugbot review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2620e5b. Configure here.

Comment thread model/name/faas.json
"name": "Serverless function execution",
"brief": "The invocation of a serverless function on a cloud provider.",
"is_in_otel": false,
"ops": ["function.aws", "function.gcp", "function.azure"],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rules omit production FAAS ops

Medium Severity

The new name and description rules list function.aws, function.gcp, and function.azure, but Sentry SDKs emit function.aws.lambda for AWS Lambda invocations. Relay matches ops exactly, so those spans will not receive faas.name-based names or descriptions.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2620e5b. Configure here.

@Lms24 Lms24 Sep 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically correct but: this op is not registered in conventions and it's no longer sent by the JS SDK in v11 (function.aws is sent instead). I think it's fine to omit for now. I might add it later once #622 lands so that we could theoretically add an op as deprecated and then use it here.

@Lms24
Lms24 marked this pull request as ready for review September 3, 2026 14:06
@Lms24
Lms24 requested review from a team, cleptric, mjq and nsdeschenes as code owners September 3, 2026 14:06
@Lms24 Lms24 self-assigned this Sep 3, 2026
@Lms24
Lms24 enabled auto-merge (squash) September 3, 2026 14:25
@Lms24
Lms24 merged commit a37ae84 into main Sep 3, 2026
14 of 17 checks passed
@Lms24
Lms24 deleted the lms/feat-faas-desc-names branch September 3, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants