feat(names): Add FAAS function span name and description rules - #617
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Names
Other
Bug Fixes 🐛
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
|
bugbot review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2620e5b. Configure here.
| "name": "Serverless function execution", | ||
| "brief": "The invocation of a serverless function on a cloud provider.", | ||
| "is_in_otel": false, | ||
| "ops": ["function.aws", "function.gcp", "function.azure"], |
There was a problem hiding this comment.
Rules omit production FAAS ops
Medium Severity
The new name and description rules list function.aws, function.gcp, and function.azure, but Sentry SDKs emit function.aws.lambda for AWS Lambda invocations. Relay matches ops exactly, so those spans will not receive faas.name-based names or descriptions.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 2620e5b. Configure here.
There was a problem hiding this comment.
technically correct but: this op is not registered in conventions and it's no longer sent by the JS SDK in v11 (function.aws is sent instead). I think it's fine to omit for now. I might add it later once #622 lands so that we could theoretically add an op as deprecated and then use it here.


Description
Adds serverless function execution span (
function.(aws|gcp|azure)) name and description rules, relying on thefaas.nameattributeref: getsentry/sentry-javascript#23954
PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)apply_scrubbing(i.e.manualorauto. Useneveronly for values that should never be scrubbed such as IDs)If an attribute was deprecated: