Skip to content

fix(descriptions): Add graphql-enhanced http.client span description template - #613

Merged
Lms24 merged 3 commits into
mainfrom
lms/fix-desc-http-client-gql
Sep 3, 2026
Merged

fix(descriptions): Add graphql-enhanced http.client span description template#613
Lms24 merged 3 commits into
mainfrom
lms/fix-desc-http-client-gql

Conversation

@Lms24

@Lms24 Lms24 commented Sep 3, 2026

Copy link
Copy Markdown
Member

The JS Browser SDK has an optional graphql client integration which identifies http.client spans that make requests to graphql endpoints. If such a request is found, the http.client span description (under transactions) was enhanced with ({{graphql.operation.type}} {{graphql.operation.name}}). This PR adds this enhancement as a rule for http.client streamed span description inference.

Technically, both operation type and name are low card. so we could also add this enhancement to span names. Gonna PR separately though since we can also decide not to do this. Decided to avoid this for now and re-add by popular demand rather than having this kind of specific rule from the get-go.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add sveltekit.* attributes emitted by SvelteKit's native spans by Lms24 in #611
  • Add browser.navigation.type, move navigation.* to router.navigation.* by logaretm in #600
  • Add langchain.chain.name (deprecated) in favor of gen_ai.pipeline.name by RulaKhaled in #599
  • Add browser.paint.type by Lms24 in #606

Names

  • Add browser.* span name and description rules by Lms24 in #607
  • Add cache span name rules by Lms24 in #605

Other

  • (descriptions) Add graphql span description rules by Lms24 in #616

Bug Fixes 🐛

  • (descriptions) Add graphql-enhanced http.client span description template by Lms24 in #613

Internal Changes 🔧

Deps

  • Bump browserslist from 4.28.2 to 4.28.8 by dependabot in #614
  • Bump fast-uri from 3.1.5 to 3.1.7 by dependabot in #612

Other

  • (descriptions) Fix http.client span description example by Lms24 in #603
  • (names) Add OTel divergence note for graphql span names by Lms24 in #615

🤖 This preview updates automatically when you update the PR.

@Lms24
Lms24 marked this pull request as ready for review September 3, 2026 07:48
@Lms24
Lms24 requested review from a team, cleptric, mjq and nsdeschenes as code owners September 3, 2026 07:48
Comment thread model/description/http.json

@nsdeschenes nsdeschenes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth taking a quick peek at that AI comment 👀

@Lms24
Lms24 enabled auto-merge (squash) September 3, 2026 11:57
@Lms24
Lms24 merged commit e27d7ce into main Sep 3, 2026
19 checks passed
@Lms24
Lms24 deleted the lms/fix-desc-http-client-gql branch September 3, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants