fix(descriptions): Add graphql-enhanced http.client span description template - #613
Merged
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Names
Other
Bug Fixes 🐛
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Lms24
marked this pull request as ready for review
September 3, 2026 07:48
Lms24
requested review from
a team,
cleptric,
mjq and
nsdeschenes
as code owners
September 3, 2026 07:48
nsdeschenes
approved these changes
Sep 3, 2026
nsdeschenes
left a comment
Contributor
There was a problem hiding this comment.
Worth taking a quick peek at that AI comment 👀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JS Browser SDK has an optional graphql client integration which identifies
http.clientspans that make requests to graphql endpoints. If such a request is found, thehttp.clientspan description (under transactions) was enhanced with({{graphql.operation.type}} {{graphql.operation.name}}). This PR adds this enhancement as a rule forhttp.clientstreamed span description inference.Technically, both operation type and name are low card. so we could also add this enhancement to span names. Gonna PR separately though since we can also decide not to do this.Decided to avoid this for now and re-add by popular demand rather than having this kind of specific rule from the get-go.