chore(names): Add OTel divergence note for graphql span names - #615
Merged
Conversation
Lms24
requested review from
a team,
cleptric,
mjq and
nsdeschenes
as code owners
September 3, 2026 08:00
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Names
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
nsdeschenes
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at graphql span names (#613) the clanker and I noticed that our span names for graphql diverge from OTel's definition, since we add a
GraphQLprefix to every name. I'm gonna assume this is on purpose (and we adjusted our span names accordingly in the SDK), so this PR adds a note that we diverge.I also thought about adding the
graphql.operation.nameattribute as an addition to a name rule but dismissed because OTel warns about potential high-cardinality in this attribute.Otel spec: https://opentelemetry.io/docs/specs/semconv/graphql/graphql-spans/