Skip to content

chore(names): Add OTel divergence note for graphql span names - #615

Merged
Lms24 merged 2 commits into
mainfrom
lms/chore-names-graphql-otel-note
Sep 3, 2026
Merged

chore(names): Add OTel divergence note for graphql span names#615
Lms24 merged 2 commits into
mainfrom
lms/chore-names-graphql-otel-note

Conversation

@Lms24

@Lms24 Lms24 commented Sep 3, 2026

Copy link
Copy Markdown
Member

While looking at graphql span names (#613) the clanker and I noticed that our span names for graphql diverge from OTel's definition, since we add a GraphQL prefix to every name. I'm gonna assume this is on purpose (and we adjusted our span names accordingly in the SDK), so this PR adds a note that we diverge.

I also thought about adding the graphql.operation.name attribute as an addition to a name rule but dismissed because OTel warns about potential high-cardinality in this attribute.

Otel spec: https://opentelemetry.io/docs/specs/semconv/graphql/graphql-spans/

@Lms24
Lms24 requested review from a team, cleptric, mjq and nsdeschenes as code owners September 3, 2026 08:00
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add sveltekit.* attributes emitted by SvelteKit's native spans by Lms24 in #611
  • Add browser.navigation.type, move navigation.* to router.navigation.* by logaretm in #600
  • Add langchain.chain.name (deprecated) in favor of gen_ai.pipeline.name by RulaKhaled in #599
  • Add browser.paint.type by Lms24 in #606

Names

  • Add browser.* span name and description rules by Lms24 in #607
  • Add cache span name rules by Lms24 in #605

Internal Changes 🔧

Deps

  • Bump browserslist from 4.28.2 to 4.28.8 by dependabot in #614
  • Bump fast-uri from 3.1.5 to 3.1.7 by dependabot in #612

Other

  • (descriptions) Fix http.client span description example by Lms24 in #603
  • (names) Add OTel divergence note for graphql span names by Lms24 in #615

🤖 This preview updates automatically when you update the PR.

@Lms24 Lms24 self-assigned this Sep 3, 2026
@Lms24
Lms24 merged commit 722fee3 into main Sep 3, 2026
17 checks passed
@Lms24
Lms24 deleted the lms/chore-names-graphql-otel-note branch September 3, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants