feat(dashboard): show conversation participant avatars #1878
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| import type { ActorIdentity } from "@sentry/junior/api/schema"; | ||
|
|
||
| import { actorLabel } from "../format"; | ||
| import { cn } from "../styles"; | ||
| import type { Conversation } from "../types"; | ||
| import { Tooltip } from "./Tooltip"; | ||
|
|
||
| const MAX_VISIBLE_PARTICIPANTS = 3; | ||
|
|
||
| type ParticipantAvatarStackProps = { | ||
| participants: readonly ActorIdentity[]; | ||
| size: "detail" | "list"; | ||
| }; | ||
|
|
||
| function participantName(participant: ActorIdentity): string { | ||
| return ( | ||
| participant.fullName?.trim() || | ||
| participant.slackUserName?.trim() || | ||
| participant.email?.trim() || | ||
| participant.slackUserId?.trim() || | ||
| "Unknown actor" | ||
| ); | ||
| } | ||
|
|
||
| function participantDescription(participant: ActorIdentity): string { | ||
| const name = participantName(participant); | ||
| const email = participant.email?.trim(); | ||
| return email && email !== name ? `${name}, ${email}` : name; | ||
| } | ||
|
|
||
| function participantInitials(participant: ActorIdentity): string { | ||
| const name = participantName(participant); | ||
| const words = name.split(/\s+/).filter(Boolean); | ||
| if (words.length > 1) { | ||
| return `${words[0]![0] ?? ""}${words.at(-1)?.[0] ?? ""}`.toUpperCase(); | ||
| } | ||
| return name.slice(0, 2).toUpperCase(); | ||
| } | ||
|
|
||
| function participantKey(participant: ActorIdentity, index: number): string { | ||
| return ( | ||
| participant.email?.trim().toLowerCase() || | ||
| participant.slackUserId?.trim() || | ||
| participant.slackUserName?.trim() || | ||
| `${actorLabel(participant) ?? "actor"}:${index}` | ||
| ); | ||
| } | ||
|
|
||
| function ParticipantTooltipContent(props: { participant: ActorIdentity }) { | ||
| const name = participantName(props.participant); | ||
| const email = props.participant.email?.trim(); | ||
| return ( | ||
| <span className="grid gap-0.5 font-sans"> | ||
| <span className="font-semibold text-dashboard-text">{name}</span> | ||
| {email && email !== name ? ( | ||
| <span className="font-mono text-dashboard-text-muted">{email}</span> | ||
| ) : null} | ||
| </span> | ||
| ); | ||
| } | ||
|
|
||
| function Avatar(props: { | ||
| participant: ActorIdentity; | ||
| size: ParticipantAvatarStackProps["size"]; | ||
| }) { | ||
| const label = participantDescription(props.participant); | ||
| return ( | ||
| <Tooltip | ||
| content={<ParticipantTooltipContent participant={props.participant} />} | ||
| focusable | ||
| triggerClassName="-ml-1.5 first:ml-0 pointer-events-none [@media(hover:hover)_and_(pointer:fine)]:pointer-events-auto" | ||
| > | ||
| <span | ||
| aria-label={label} | ||
| className={cn( | ||
| "relative inline-grid shrink-0 place-items-center rounded-full border-2 border-dashboard-bg bg-dashboard-focus font-sans font-bold leading-none text-dashboard-text-inverse shadow-sm focus-visible:z-10 focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-1 focus-visible:outline-dashboard-focus", | ||
| props.size === "list" ? "size-6 text-2xs" : "size-7 text-xs", | ||
| )} | ||
| onKeyDown={(event) => event.stopPropagation()} | ||
| tabIndex={0} | ||
| > | ||
| {participantInitials(props.participant)} | ||
| </span> | ||
| </Tooltip> | ||
| ); | ||
| } | ||
|
|
||
| /** Use projected participants, with the root actor as a legacy fallback. */ | ||
| export function conversationParticipants( | ||
| conversation: Conversation | undefined, | ||
| ): readonly ActorIdentity[] { | ||
| if (conversation?.participants?.length) return conversation.participants; | ||
| return conversation?.actorIdentity ? [conversation.actorIdentity] : []; | ||
| } | ||
|
|
||
| /** Show Conversation actors in first-appearance order. */ | ||
| export function ParticipantAvatarStack(props: ParticipantAvatarStackProps) { | ||
| if (props.participants.length === 0) return null; | ||
| const visible = props.participants.slice(0, MAX_VISIBLE_PARTICIPANTS); | ||
| const hidden = props.participants.slice(MAX_VISIBLE_PARTICIPANTS); | ||
| const label = props.participants.map(participantDescription).join("; "); | ||
| return ( | ||
| <span | ||
| aria-label={`Conversation participants: ${label}`} | ||
| className="inline-flex items-center" | ||
| role="group" | ||
| > | ||
| {visible.map((participant, index) => ( | ||
| <Avatar | ||
| key={participantKey(participant, index)} | ||
| participant={participant} | ||
| size={props.size} | ||
| /> | ||
| ))} | ||
| {hidden.length > 0 ? ( | ||
| <Tooltip | ||
| content={ | ||
| <span className="grid gap-1 font-sans"> | ||
| {hidden.map((participant, index) => ( | ||
| <span key={participantKey(participant, index)}> | ||
| {participantDescription(participant)} | ||
| </span> | ||
| ))} | ||
| </span> | ||
| } | ||
| focusable | ||
| triggerClassName="-ml-1.5 pointer-events-none [@media(hover:hover)_and_(pointer:fine)]:pointer-events-auto" | ||
| > | ||
| <span | ||
| aria-label={`${hidden.length} more participants: ${hidden | ||
| .map(participantDescription) | ||
| .join("; ")}`} | ||
| className={cn( | ||
| "relative inline-grid shrink-0 place-items-center rounded-full border-2 border-dashboard-bg bg-dashboard-fill-strong font-mono font-semibold leading-none text-dashboard-text-muted focus-visible:z-10 focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-1 focus-visible:outline-dashboard-focus", | ||
| props.size === "list" ? "size-6 text-2xs" : "size-7 text-xs", | ||
| )} | ||
| onKeyDown={(event) => event.stopPropagation()} | ||
| tabIndex={0} | ||
| > | ||
| +{hidden.length} | ||
| </span> | ||
| </Tooltip> | ||
| ) : null} | ||
| </span> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,7 @@ type TooltipProps = { | |
| children: ReactElement; | ||
| className?: string; | ||
| content: ReactNode; | ||
| focusable?: boolean; | ||
| label?: ReactNode; | ||
| placement?: "above" | "below"; | ||
| triggerClassName?: string; | ||
|
|
@@ -51,6 +52,7 @@ export function Tooltip({ | |
| children, | ||
| className, | ||
| content, | ||
| focusable = false, | ||
| label, | ||
| placement = "above", | ||
| triggerClassName, | ||
|
|
@@ -121,6 +123,8 @@ export function Tooltip({ | |
| <HoverCard.Trigger | ||
| aria-describedby={open ? tooltipId : undefined} | ||
| asChild | ||
| onBlur={focusable ? () => setOpen(false) : undefined} | ||
| onFocus={focusable ? () => setOpen(true) : undefined} | ||
|
There was a problem hiding this comment. Focused tooltip closes before copyLow Severity The new Additional Locations (1)  Reviewed by Cursor Bugbot for commit 663d50e. Configure here. |
||
| onPointerCancel={() => { | ||
| touchStartedOpenRef.current = null; | ||
| }} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avatars block clicks without tooltips
Medium Severity
Avatar triggers opt back into pointer events for any hover-capable fine pointer, but
Tooltiponly mounts atmin-width: 768px. On home cards the footer stayspointer-events-noneover the overlayLink, so a narrow desktop window captures clicks on the stack without showing a tooltip or opening the conversation.Additional Locations (2)
packages/junior-dashboard/src/client/components/ParticipantAvatarStack.tsx#L126-L127packages/junior-dashboard/src/client/conversations/ConversationHomeList.tsx#L274-L282Reviewed by Cursor Bugbot for commit 663d50e. Configure here.