feat(dashboard): show conversation participant avatars - #1878
Conversation
Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
8 screenshot changes — 8 changed · 0 added · 0 removed Review screenshots in Frameshift
Show 2 more changed screenshots
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 663d50e. Configure here.
| <Tooltip | ||
| content={<ParticipantTooltipContent participant={props.participant} />} | ||
| focusable | ||
| triggerClassName="-ml-1.5 first:ml-0 pointer-events-none [@media(hover:hover)_and_(pointer:fine)]:pointer-events-auto" |
There was a problem hiding this comment.
Avatars block clicks without tooltips
Medium Severity
Avatar triggers opt back into pointer events for any hover-capable fine pointer, but Tooltip only mounts at min-width: 768px. On home cards the footer stays pointer-events-none over the overlay Link, so a narrow desktop window captures clicks on the stack without showing a tooltip or opening the conversation.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 663d50e. Configure here.
| aria-describedby={open ? tooltipId : undefined} | ||
| asChild | ||
| onBlur={focusable ? () => setOpen(false) : undefined} | ||
| onFocus={focusable ? () => setOpen(true) : undefined} |
There was a problem hiding this comment.
Focused tooltip closes before copy
Low Severity
The new focusable path closes the tooltip on trigger blur. After keyboard focus or a click on an avatar, moving to the popup to select the name or email dismisses it, so the selectable participant details cannot be copied.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 663d50e. Configure here.
1 participant
Replace the visible Conversation author label with an avatar stack across home cards, list rows, and Conversation details.
+NoverflowVisual QA covered the desktop home and detail views, hover and keyboard tooltips, and the mobile home view. Evidence is attached in the Slack thread because the screenshots include mock participant names and emails.
Checks:
pnpm --filter @sentry/junior typecheckpnpm --filter @sentry/junior-dashboard typecheckpnpm --filter @sentry/junior lintpnpm --filter @sentry/junior-dashboard lintpnpm dashboard-style:checkpnpm test-architecture:checkpnpm --filter @sentry/junior exec vitest run integration/api/conversations/list.test.tsvia David Cramer.
--
View Junior Session [Sentry]