Skip to content

docs(testing): log the 1.9.5-rc.2 regression pass - #369

Merged
EtienneLescot merged 1 commit into
mainfrom
claude/e2e-log-1-9-5-rc2
Aug 14, 2026
Merged

docs(testing): log the 1.9.5-rc.2 regression pass#369
EtienneLescot merged 1 commit into
mainfrom
claude/e2e-log-1-9-5-rc2

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

What

The manual e2e record for the 1.9.5-rc.2 candidate, plus the one correction this pass made to its own instructions.

Scope was deliberately the 65 commits since v1.9.2, not the rc.2 delta — a release candidate is judged against the last thing users actually installed. ~20 of those commits are in the Windows capture helper, so the net is weighted there.

Run against release/v1.9.5 @ b1b81de5 with the CI-built rc.1 native payload. That payload is the rc.2 payload: nothing under electron/native/ or crates/ changed since the rc.1 tag, verified by diffing the file list.

Result: pass, no defect

Four recordings. Highlights, all measured rather than eyeballed:

Not covered, and why

DPI scaling (60bb6d7c, 71cc88d6) — not re-run here; already validated when those two landed. My first draft of this row said "this machine is at 100 %, those bugs are structurally invisible here", which is wrong: the display scale is a setting, changing it takes about two minutes, and doing so has been the documented procedure since #346. Skipping was a choice, and the record now says so rather than dressing it up as a constraint. Webcam PiP and the export webcam fixes (056cfc39, 26ad478c) — no camera in the loop. Microphone, GIF, macOS/Linux, AI sections, packaging.

The AGENTS.md change

Yesterday's staleness warning said to date "the binary". So I refreshed the capture helper and nothing else — and the export then died on:

native bridge compositor.exportMulti failed: open_input: -22 (Invalid argument)

That reads exactly like a product regression, and I nearly reported it as one. The recording was fine: ffmpeg -f null - opened the same file from the command line and decoded it end to end. The compositor addon was four days older than the av* DLLs it was built against. A full hash diff of electron/native/bin/<platform>/ turned up sixteen files differing and two missing outright.

Copying the whole directory and re-running the identical export made it pass. So the unit of staleness is the directory, not the binary, and the doc now says so — with the failure mode named, because "mismatched native set" presents as a bug in whatever you happened to be testing.

Checks

node scripts/check-docs.mjs → OK (31 files). Docs only; no code touched.

The checklist run this records covers the 65 commits since v1.9.2 rather
than the rc.2 delta, which is what a release candidate actually needs.
Four recordings; no defect found. The numbers that matter are in the row.

The AGENTS.md addition is the one thing this pass got wrong about itself.
The staleness warning I wrote yesterday said to date "the binary" — so I
refreshed the capture helper and nothing else, and an export then died on
`open_input: -22 (Invalid argument)` out of `compositor.exportMulti`. It
reads exactly like a product bug, and I nearly filed it as one. The file
was fine: `ffmpeg` opened it from the command line without complaint. The
compositor addon was four days older than the av* DLLs it was built
against. A full hash diff of the directory found sixteen files differing
and two missing outright.

So the unit is the directory, not the binary. Copy all of it and diff by
hash, or a mismatched set will hand you a failure that looks like the
thing you came to test.
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 24097f2f-d29c-4d66-8db4-c7d503809706

📥 Commits

Reviewing files that changed from the base of the PR and between d5b1e8f and e489164.

📒 Files selected for processing (2)
  • AGENTS.md
  • technical-documentation/testing/manual-e2e-checklist.md

📝 Walkthrough

Walkthrough

The pull request updates native-binary refresh guidance and adds a Windows 11 release regression-test result for recording, recovery, synchronization, rendering, persistence, refocus, and export.

Changes

Release documentation

Layer / File(s) Summary
Native-binary refresh guidance
AGENTS.md
The guidance requires copying the complete platform-specific native binary directory and verifying file hashes.
Windows release regression result
technical-documentation/testing/manual-e2e-checklist.md
The checklist records passing Windows 11 release/v1.9.5 tests and lists untested platform and feature areas.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to e4891

This PR only records manual testing results and clarifies documentation for refreshing the native-file directory; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the primary change: documenting the 1.9.5-rc.2 regression test pass.
Description check ✅ Passed The description is detailed, on-topic, and documents the testing scope, results, limitations, native-directory correction, and validation command.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/e2e-log-1-9-5-rc2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant