docs(testing): "the machine is at 100%" is not a reason to skip DPI - #372
Conversation
The row justified skipping DPI coverage with "this machine is 100% — those bugs are structurally invisible here". The display scale is a setting. Changing it takes about two minutes and has been the documented procedure since #346, so the honest sentence was "not re-run in this pass", not "cannot be tested here". Left as not-covered, because it was already validated when 60bb6d7 and 71cc88d landed, but the reason now says that instead of dressing a choice up as a constraint — which is exactly how a gap outlives the release it was skipped for.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Windows release regression log now includes broader validation results and updated guidance for re-testing DPI scaling. ChangesWindows regression documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a one-line documentation correction with no production behavior change, so no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #369, which merged one commit before this one landed.
The results row justified skipping DPI coverage with "this machine is 100% — those bugs are structurally invisible here". That is wrong, and wrong in a way worth correcting in the record rather than quietly: the display scale is a setting. Changing it takes about two minutes, and driving Settings to do it has been the documented procedure since #346.
So the honest sentence is "not re-run in this pass" — it was already validated when
60bb6d7cand71cc88d6landed. Skipping was a choice. Left skipped, but the reason now says that instead of dressing a choice up as a constraint, which is exactly how a coverage gap outlives the release it was skipped for.One line, docs only.
check-docsgreen.Summary by CodeRabbit