Skip to content

fix: the refusal of an expiry that is not a date says a form, not an example #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rodrigoteamx merged 1 commit into from
Oct 11, 2026
Merged

fix: the refusal of an expiry that is not a date says a form, not an example #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Standing/StandingGrant.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ public static function fromArray(array $data): self
$expires = $data['expires_at'] ?? null;
$expiresAt = \is_string($expires) ? date_create_immutable($expires) : null;
if ($expires !== null && !$expiresAt instanceof \DateTimeImmutable) {
throw new \InvalidArgumentException("{$where} gives «expires_at» as a date and time, e.g. 2026-12-31T00:00:00Z");
throw new \InvalidArgumentException("{$where} gives «expires_at» as a date and time with its offset, in ISO 8601");
}

$supersedes = $data['supersedes'] ?? null;
Expand Down
4 changes: 2 additions & 2 deletions tests/Standing/AStandingGrantNeverCrossesItsFloorsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ public static function documentsThatAreRefused(): iterable
['name' => 'c', 'statement' => 't', 'by' => ['operation' => 'lab:build']],
]], 'each under its own name'];
yield 'conditions not given as a list' => [['conditions' => ['c' => ['name' => 'c']]], 'gives «conditions» as a list'];
yield 'an expiry that is not a date' => [['expires_at' => 'next week, maybe'], 'gives «expires_at» as a date and time'];
yield 'an expiry that is not text' => [['expires_at' => 1790000000], 'gives «expires_at» as a date and time'];
yield 'an expiry that is not a date' => [['expires_at' => 'next week, maybe'], 'gives «expires_at» as a date and time with its offset, in ISO 8601'];
yield 'an expiry that is not text' => [['expires_at' => 1790000000], 'gives «expires_at» as a date and time with its offset, in ISO 8601'];
}

public function testTheValuesRefuseTheSameThingsWhenBuiltByHand(): void
Expand Down
Loading