Repository navigation
fix: the refusal of an expiry that is not a date says a form, not an example - #83
Merged
Merged
Conversation
…example A grant whose «expires_at» cannot be read was refused with «… as a date and time, e.g. 2026-12-31T00:00:00Z». Nothing a package of the family says gives a concrete example where a form will do (greenhouse decisions/0598), and the gate that asks it of the published family went red on this one sentence the day 0.30.0 was released: 465 examples, 464 forms, this one. It now says «as a date and time with its offset, in ISO 8601». With that sentence in a house born of the published family, the same gate is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence, and the two tests that read it.
Why
milpa/command0.30.0 refuses a grant whoseexpires_atcannot be read with «… as a date and time, e.g. 2026-12-31T00:00:00Z». Nothing a package of the family says gives a concrete example where a form will do (greenhouse decisions/0598), and greenhouse's gate over the published family — «The family says a form and ships no tests» — went red on this one sentence once 0.30.0 was in the registry: 465 examples, 464 forms, and this one. The gate reads theT00of the timestamp as a name nobody reviewed.It was green on greenhouse's
mainin its last run, which was before the release; the next push there will be red until this is released.What changes
The refusal now says «as a date and time with its offset, in ISO 8601». No behaviour changes: the same documents are refused.
Checked
AStandingGrantNeverCrossesItsFloorsTestthat read this refusal were made to ask for the new sentence first, and failed on 0.30.0; they pass now.vendor/bin/phpunit --testsuite Command: 338 tests, 1049 assertions; line coverage 100.00% (1270/1270). php-cs-fixer and PHPStan pass.name a domain: 1, NEW: 1), and green with this sentence put into that house (469 examples, 469 forms). That second house also carried feat: the house judges a standing grant before a seat's act (greenhouse decisions/0615) app-runtime#797's branch, which adds five examples, all of them forms.What was missed
This gate was not run against the branch of #81 before it merged. It can be: it reads a house, and a branch can be put into one.