Skip to content

fix: the hint beside a refusal says where the cure is, when it is not in the file - #758

Merged
rodrigoteamx merged 3 commits into
mainfrom
hp/greenhouse/t-0092-the-hint-beside-a-refusal-says-where-the-cure-is
Oct 8, 2026
Merged

rodrigoteamx merged 3 commits into
mainfrom
hp/greenhouse/t-0092-the-hint-beside-a-refusal-says-where-the-cure-is

Conversation

@rodrigoteamx

Copy link
Copy Markdown
Contributor

Why

The landing gate can refuse a body for a reason that is not in the body, and say itself what cures it. Beside such a refusal the trial's summary still wrote its generic hint, and the summary comes first:

Measured with the scripted stand-in, in greenhouse evidence/1156.

What changes

TrialFailureSummary writes a hint of its own for those two refusals: the file can be right as it is, where the cure is, and to send the same implement again.

  • phase collaborators;
  • phase behavior, when the gate named the scaffolds its judge runs over (diagnostic.scaffolds, a non-empty list of names).

What does not change

  • Every other rejection keeps the hint it had, the recorded one and the unrecorded one.
  • The parts door keeps its own: a staged file is amended, whatever phase refused it.
  • With the published devtools neither the phase nor the key appears, so this changes nothing until those two pull requests are in a house. No floor is needed and the order of merging does not matter.

Tests

  • 4 tests: 2 written red first, 2 pin what does not change. One case was added to a pin after the code, for a mutant.
  • Suite: 3,802. 11 hand mutants, all killed. PHPStan, the formatter and the docblock gate are clean.

Said plainly

Nothing ran with a resident. The hint is words; whether they are followed is for the next run.

… in the file

The landing gate refuses an operation whose run() the house cannot hand what it takes, and writes
out the edit of the plugin's entry that cures it. Beside that refusal the trial's summary said
«Resubmit the complete corrected file with implement… edit with source would be refused»: two
instructions for one refusal, and the summary's comes first (greenhouse evidence/1156).

Two refusals say themselves what cures them, and neither cure is a corrected body: an operation the
house cannot hand what it takes (phase collaborators), and a judge red over operations that are
still scaffolds (phase behavior, with the scaffolds the gate named). For those the hint now says
the file can be right as it is, where the cure is, and to send the same implement again.

Every other rejection keeps the hint it had, and so does the parts door.
@rodrigoteamx
rodrigoteamx merged commit 4430bd9 into main Oct 8, 2026
2 checks passed
rodrigoteamx added a commit that referenced this pull request Oct 8, 2026
, #752, #757)

Main carries #752 and #757 squashed, so what this branch had built on them came back as conflicts,
nine regions in five files, each resolved by what it is:

- SessionToolGate.php: two new methods at the same place — main's whatAYesDoes (#756) first, then this
  branch's source of «named» (decisions/0602). #761's lines in that file are main's and are kept.
- SeatFrontier.php and SessionOperations.php, the informed grant: main has #752's lines; this branch has
  the same lines with what 0602 adds — the fact of how far a grant reaches, and the sentence said
  before the act. This branch's.
- SessionOperations.php, the notice after an admission: main's, as #756 and #752 were resolved together.
- the two tests: what this branch adds where main has nothing.

The result is, hash for hash in src/, tests/, resources/ and composer.json, what a merge that knows
#752 and #757 as ancestors gives.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant