test: the guardian of repair hints provokes the phase «collaborators» and follows its hint

[rodrigoteamx]

Main is red for everyone since DevTools 0.44.2 is on Packagist. This is the fix: one test file, no source.

What happened

milpa/devtools 0.44.2 added a phase to its landing gate — collaborators: an operation whose run() the house cannot hand what it works through is refused when its code lands (devtools#148, greenhouse evidence/1154).

ARepairHintNamesACallTheHouseAdmitsTest reads the phases from the installed DevTools and fails by name when it has no judge to provoke one. So main at e81acb4, resolved without a lock, fails nine tests, all in that class:

• testEveryPhaseOfTheInstalledGateIsOneThisGuardianCanProvoke — «a phase this guardian cannot provoke has a hint nobody follows; teach the judges in house() to reject with it»;
• eight data sets of testTheCallAHintNamesIsOneTheHouseRuns, all collaborators · ….

Main's last CI is green because it ran with 0.44.1. t-0104 found it and reproduced it on a clean checkout; I reproduced it here. The phase is mine — it came with devtools#148 — and I did not run this suite against it before that release. The guardian did what it is there for.

What was missing

Nothing in src/. The runtime already writes the hint for this phase (#758): «This file can be right as it is … Make the edit this refusal writes out on the plugin class — a plain edit with find and replace, and no source —, promote it, and send this same implement again.» The fixture did not know the phase:

• The stand-in for the construction probe now answers the way the probe does for such an operation: the class is built, and operation: {handed: false, unhanded: […]}.
• A test class is not judged by it, as it is not by the other two judges that build or run a class.
• The guardian follows the hint it gets. It is the fourth shape of hint: the cure is not in the refused file. The call it names is a plain edit of the plugin class — the fixture house now has one — and the house runs that call, for a seat holding plugins.Blog:write and for the terminal.

Measured

• With DevTools 0.44.2: the class goes from 42 tests, 9 failures to 42 tests green.
• Five mutants by hand, five killed: the probe never says it; a test class expected to be rejected by it; the guardian not knowing the hint; no plugin class to edit; an edit that finds nothing.
• With 0.44.1 nothing changes: the phases are read from what is installed, and the new branches are not reached.

What this does not do

• It does not raise the floor for DevTools. conflict: milpa/devtools <0.44.1 stays: the runtime works with both, and the hint for the phase has been in main since fix: the hint beside a refusal says where the cure is, when it is not in the file #758.
• I ran this class and the formatter here, not the whole suite: the machine is running the reference run. CI runs the whole.