Skip to content

fix(core): fall back to raw XML when pretty-printing fails #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
C1-BA-B1-F3 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

fix(core): fall back to raw XML when pretty-printing fails #363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pygeometa/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,8 +413,12 @@ def pretty_print(xml: str) -> str:
"""

LOGGER.debug('pretty-printing XML')
val = minidom.parseString(xml)
return '\n'.join([val for val in val.toprettyxml(indent=' '*2).split('\n') if val.strip()]) # noqa
try:
val = minidom.parseString(xml)
return '\n'.join([val for val in val.toprettyxml(indent=' '*2).split('\n') if val.strip()]) # noqa
except Exception as err:
LOGGER.warning(f'pretty-printing failed: {err}; returning raw XML')
return xml


def render_j2_template(mcf: dict, template_dir: str = None) -> str:
Expand Down