fix(core): fall back to raw XML when pretty-printing fails - #363
Open
C1-BA-B1-F3 wants to merge 1 commit into
Open
C1-BA-B1-F3 wants to merge 1 commit into
C1-BA-B1-F3 wants to merge 1 commit into
Conversation
minidom.parseString raises ExpatError on XML with unescaped special characters (e.g. an '&' in a creation date), crashing the whole metadata generation. Catch the error, log it, and return the raw XML so the user still gets usable output. Fixes geopython#336
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minidom.parseStringraisesExpatErrorwhen the rendered XML contains unescaped special characters (e.g. an&in a creation date), crashing the whole metadata generation with no output.Fix
Catch the error in
pretty_print, log a warning, and return the raw XML so the user still gets usable output.Test plan
&) returns raw XML with a logged warning instead of raising.Fixes #336