fix: game-ci test --docker defaulted to an image that can't actually run tests - #101
Merged
Merged
Conversation
…run tests Root cause found via set -x tracing (#99) on a real CI failure: every Docker test run exited near-instantly with exit code 1 and zero log output, even though activation succeeded fine moments earlier. --docker defaulted targetPlatform to NoTarget, resolving to RunnerImageTag's 'base' editor module - the same image activate/build's NoTarget path already uses successfully. But activation only needs the editor to launch and exit; running tests needs it to actually compile and execute test assemblies, which 'base' apparently can't do (no Unity log output was ever written, meaning it failed before even initializing far enough to open the log file). unity-test-runner's own original ImageTag never defaulted to NoTarget at all - it defaulted to this host's *native* Standalone target (getImagePlatformType: StandaloneLinux64 on Linux, StandaloneWindows on Windows), which resolves to the linux-il2cpp module for Unity 2020+. Matching that default here instead. Also removes the temporary set -x tracing from runsteps.sh (#99) now that it's served its purpose and found the actual bug, and fixes the default to read from `options.hostPlatform` (already resolved per- invocation) rather than raw `process.platform`, which was also just untestable rather than reading the actual runtime value. Testing: full bun test suite 156 pass/0 fail (updated one test's assertion from the old, wrong 'base' expectation to the new correct linux-il2cpp one), bun build succeeds. Will re-verify against a real Docker test run once this lands and a release is cut.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
frostebite
added a commit
that referenced
this pull request
Aug 18, 2026
frostebite
added a commit
that referenced
this pull request
Aug 18, 2026
#101 fixed the wrong default image (linux-il2cpp now pulled correctly, confirmed in CI), but the Docker test run still fails the same way. Need to see if it's the same symptom or a new one against the correct image. Temporary - will remove once root-caused.
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause found via
set -xtracing (#99) on a real CI failure: every Docker test run onunity-test-runner's thin-wrapper PR (#310) exited near-instantly with exit code 1 and zero log output, even though activation succeeded fine moments earlier in the same run.Root cause
--dockerdefaultedtargetPlatformtoNoTarget, resolving toRunnerImageTag'sbaseeditor module — the same imageactivate/build'sNoTargetpath already uses successfully. But activation only needs the editor to launch and exit; running tests needs it to actually compile and execute test assemblies, whichbaseapparently can't do (no Unity log output was ever written at all, meaning it failed before even initializing far enough to open the log file).unity-test-runner's own originalImageTagnever defaulted toNoTarget— it defaulted to this host's native Standalone target (getImagePlatformType:StandaloneLinux64on Linux,StandaloneWindowson Windows), which resolves to thelinux-il2cppmodule for Unity 2020+. Matching that default here instead.Also in this PR
set -xtracing fromrunsteps.sh(debug: trace runsteps.sh execution to diagnose a real CI failure #99) now that it's served its purpose.options.hostPlatform(already resolved per-invocation) rather than rawprocess.platformdirectly inexecuteDocker— was also just untestable, not only stylistic.Testing
bun test ./src: 156 pass, 0 fail (updated one test's assertion from the old, wrongbaseexpectation to the correctlinux-il2cppone).bun buildsucceeds.🤖 Generated with Claude Code